Skip to content

Smooth theme toggle — prevent flash and double-toggle #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kronpatel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Smooth theme toggle — prevent flash and double-toggle #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions components/shared/theme-toggle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,28 @@ import { useEffect, useState } from "react";
export default function ModeToggle() {
const { theme, setTheme } = useTheme();
const [mounted, setMounted] = useState(false);
const [isChanging, setIsChanging] = useState(false);

// Wait for component to mount before rendering icons
useEffect(() => {
setMounted(true);
}, []);

// Add smooth transition when theme changes
useEffect(() => {
if (mounted) {
document.documentElement.style.transition = "background-color 0.3s ease-in-out, color 0.3s ease-in-out";
return () => {
document.documentElement.style.transition = "";
};
}
}, [mounted]);

const toggleTheme = () => {
setIsChanging(true);
setTheme(theme === "light" ? "dark" : "light");
// Reset changing state after transition
setTimeout(() => setIsChanging(false), 300);
};

// Prevent rendering on server to avoid hydration mismatch
Expand All @@ -26,10 +40,19 @@ export default function ModeToggle() {
onClick={toggleTheme}
whileTap={{ rotate: 180 }}
transition={{ duration: 0.3 }}
className="px-2 rounded-full transition flex items-center justify-center"
className={`px-2 rounded-full transition-all duration-300 flex items-center justify-center ${
isChanging ? 'opacity-50' : 'opacity-100'
}`}
aria-label="Toggle theme"
disabled={isChanging}
>
{theme === "light" ? <Moon size={18} /> : <Sun size={18} />}
<motion.div
initial={false}
animate={{ rotate: theme === 'light' ? 0 : 180 }}
transition={{ duration: 0.3 }}
>
{theme === "light" ? <Moon size={18} /> : <Sun size={18} />}
</motion.div>
</motion.button>
);
}