Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an option to disable request body compression, giving users control over when compression should be applied.
- Renames test case fields from compressPayload to enableRequestCompression and adds payloadWasCompressed to better reflect compression behavior.
- Updates NewWebhookDispatcher to default request compression to enabled and includes new tests to verify the EnableCompression functionality.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dispatcher_test.go | Updated test cases to use new compression-related flags. |
| dispatcher.go | Added documentation and logic for optional request compression. |
aogz
approved these changes
Mar 13, 2025
Vamxi
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr introduces an option to disable compression. Our vrec payload is small anyway and drf doesn't support zstd