Skip to content

For review#1

Merged
jsnjack merged 40 commits intomasterfrom
for_review
Mar 12, 2025
Merged

For review#1
jsnjack merged 40 commits intomasterfrom
for_review

Conversation

@jsnjack
Copy link
Member

@jsnjack jsnjack commented Mar 10, 2025

This is the package I mentioned during the standup to deliver webhooks. Note, this a public repository

@jsnjack jsnjack requested a review from Copilot March 10, 2025 09:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR introduces a webhook dispatcher package in Go with support for reliable webhook delivery, automatic retries, concurrency, and payload compression. Key changes include the implementation of a main example for launching the dispatcher, comprehensive tests for retry logic in events, and full dispatcher/event logic with accompanying documentation updates.

Reviewed Changes

File Description
examples/main.go Launches the dispatcher and provides an HTTP handler for generating events
event_test.go Adds tests to verify retry logic in event processing
dispatcher.go Implements core dispatcher logic including worker management and retry scheduling
event.go Defines the event model along with helper functions for event handling and retry logic
README.md Provides detailed documentation and usage instructions for the package

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

@jsnjack jsnjack requested review from Vamxi and aogz March 11, 2025 13:19
@jsnjack jsnjack requested a review from Copilot March 11, 2025 14:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces a webhook dispatcher package for reliable webhook delivery, including CI workflow integration, documentation updates, usage examples, tests, and core dispatcher functionality.

  • Added a GitHub Actions CI workflow to run tests and linting.
  • Provided comprehensive README documentation and examples for both basic and advanced usage.
  • Implemented and tested core dispatcher components such as event queuing, retry logic, and graceful shutdown.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/on_commit.yml Added CI workflow for building, linting, and testing.
README.md New documentation outlining package features and usage.
examples/main.go Example demonstrating basic server usage.
event_test.go New tests for retry time calculation.
event.go Added event and retry management functionality.
dispatcher.go Core dispatcher implementation with event handling.
.golangci.yaml New golangci-lint configuration.

@jsnjack jsnjack merged commit eb4545a into master Mar 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants