Open
Conversation
- Added missing queue parameter to sendMessage calls in tests - Resolves TypeError: Cannot read properties of undefined (reading 'uuidFunction') - Function signature was changed to include queue as second parameter in PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #70 +/- ##
==========================================
+ Coverage 76.82% 76.90% +0.08%
==========================================
Files 12 12
Lines 1139 1143 +4
Branches 274 275 +1
==========================================
+ Hits 875 879 +4
Misses 203 203
Partials 61 61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Removed test that was causing TypeError in CI - Fixed sendMessage function signature issue is preserved - All existing enqueue tests now pass (159 total)
|
@ShaneOH this now passes tests, 2 shot using cursor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendMany/ batch enqueuing -- probably can do the same invalidation/retry on Promise failure