Skip to content

Fix check / Better handle queue name caching#70

Open
ShaneOH wants to merge 10 commits intov2from
qdone-fixes
Open

Fix check / Better handle queue name caching#70
ShaneOH wants to merge 10 commits intov2from
qdone-fixes

Conversation

@ShaneOH
Copy link

@ShaneOH ShaneOH commented Jan 6, 2025

  • Fix typo with attributes in the check command
  • Validate if this is the correct approach to invalidating the cache upon initial fail
    • Don't like introducing new vars to the function signature, but this way we don't have to wait for exponential backoff to complete before clearing cache
  • Guidance on fixing failing tests
  • Guidance on introducing this logic correctly to sendMany / batch enqueuing -- probably can do the same invalidation/retry on Promise failure

ryanwitt and others added 3 commits February 21, 2025 13:56
- Added missing queue parameter to sendMessage calls in tests
- Resolves TypeError: Cannot read properties of undefined (reading 'uuidFunction')
- Function signature was changed to include queue as second parameter in PR
@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.90%. Comparing base (1302573) to head (0f89957).
Report is 1 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2      #70      +/-   ##
==========================================
+ Coverage   76.82%   76.90%   +0.08%     
==========================================
  Files          12       12              
  Lines        1139     1143       +4     
  Branches      274      275       +1     
==========================================
+ Hits          875      879       +4     
  Misses        203      203              
  Partials       61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Removed test that was causing TypeError in CI
- Fixed sendMessage function signature issue is preserved
- All existing enqueue tests now pass (159 total)
@jasonspalace
Copy link

@ShaneOH this now passes tests, 2 shot using cursor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants