Let blacklisted foods perform default behavior#5
Open
Tidy-Bear wants to merge 1 commit intosuppergerrie2:masterfrom
Open
Let blacklisted foods perform default behavior#5Tidy-Bear wants to merge 1 commit intosuppergerrie2:masterfrom
Tidy-Bear wants to merge 1 commit intosuppergerrie2:masterfrom
Conversation
…ull. Signed-off-by: Tidy-Bear <ChenTidyBear@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the food does not meet the criteria, do nothing and execute the default behavior instead of directly canceling the event.
Combined with the configuration file, this can solve issues such as #3 and #4, at the cost that these items cannot be consumed when the hunger value is full.
Personal idea: Using mixin again maybe better?
Inject into
MultiPlayerGameMode#useItem(Player, InteractionHand)andServerPlayerGameMode#useItem(ServerPlayer, Level, ItemStack, InteractionHand), after callingItemStack#use(Level, Player, InteractionHand), decide whether to trigger mod's logic based on the returnedInteractionResult.Closes
Close #3
Close #4