Make extraScope can access in trigger rules#382
Open
golfapipol wants to merge 1 commit intosuperscriptjs:masterfrom
Open
Make extraScope can access in trigger rules#382golfapipol wants to merge 1 commit intosuperscriptjs:masterfrom
golfapipol wants to merge 1 commit intosuperscriptjs:masterfrom
Conversation
uncommnet line:156 in helpers.js that make extraScope cannot use in trigger rules modified: src/bot/getReply/helpers.js
Contributor
Author
|
I think we should change filterScope.message_props to filterScope.extraScope or not? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uncommnet line:156 in helpers.js that make extraScope cannot use in trigger rules
use options.system.extraScope instead of old one
Description
uncommnet line:156 in helpers.js that make extraScope cannot use in trigger rules
use options.system.extraScope instead of old one
Motivation and Context
I want to use extraScope in trigger rules and found this commented code here
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: