Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- haystack_pydantic/core/pipeline/pipeline.py: Evaluated as low risk
- haystack_pydantic/init.py: Evaluated as low risk
Comments suppressed due to low confidence (3)
.github/workflows/lint_and_test.yml:39
- The command 'poetry run ruff format --check .' is unconventional for formatting checks. Consider using 'poetry run black --check .' instead.
poetry run ruff format --check .
haystack_pydantic/core/component/init.py:14
- [nitpick] The variable name 'component' is ambiguous as it conflicts with the imported 'component' module. Consider renaming it to avoid confusion.
component: _Component = cast(_Component, component_module.component)
tests/test_integration.py:36
- The
connectmethod inpipeline.pyshould have a dedicated test to verify its functionality.
pipeline.connect("sample_comp1.attr1", "sample_comp2.input1")
| # if it's not available, we fallback to the output_types decorator | ||
| output_type = inspect.signature(run_func).return_annotation | ||
| output_sockets: Mapping[str, InputSocket | OutputSocket] | ||
| if issubclass(output_type, BaseModel): |
There was a problem hiding this comment.
Add a guard check to ensure output_type is a class before calling issubclass to prevent potential TypeError. Update the error message to be more specific.
Suggested change
| if issubclass(output_type, BaseModel): | |
| if isinstance(output_type, type) and issubclass(output_type, BaseModel): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.