Skip to content

feat: web version full viewport height #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peronczyk wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −15
Open

feat: web version full viewport height #3197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/popup/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,6 @@ export default defineComponent({

.app {
--screen-padding-x: 16px;
--screen-border-radius: 0;
--screen-bg-color: #{$color-bg-app};
--header-height: 0;
--gap: 12px;
Expand All @@ -314,7 +313,6 @@ export default defineComponent({
margin: 0 auto;
width: 100%;
height: 100%;
border-radius: var(--screen-border-radius);
color: $color-white;
background-color: var(--screen-bg-color);
font-family: $font-sans;
Expand Down Expand Up @@ -362,17 +360,11 @@ export default defineComponent({
}

@include mixins.env-web {
// Imitate the appearance of the mobile/extension app by displaying it in a box
// TODO consider full-screen
@include mixins.desktop {
--screen-border-radius: #{$border-radius-app};

width: $extension-width;
height: $extension-height;
max-width: $phone-width;

@include mixins.desktop {
.app-wrapper {
overflow: hidden;
box-shadow: $color-border 0 0 0 1px;
transform: translate(0, 0); // Create custom viewport for fixed elements
}
}
Expand Down
5 changes: 0 additions & 5 deletions src/popup/components/Modal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,11 +279,6 @@ export default defineComponent({
&.from-bottom {
position: absolute;
align-items: end;

.container {
border-bottom-left-radius: var(--screen-border-radius);
border-bottom-right-radius: var(--screen-border-radius);
}
}

&.has-header {
Expand Down