Open
Conversation
ifaouibadi
requested review from
CedrikNikita,
konradodo,
peronczyk,
pstachel and
subhod-i
|
Deployed to features-websocket.wallet.z52da5wt.xyz, artifacts |
ifaouibadi
force-pushed
the
features/websocket
branch
from
32506ee to
1267808
Compare
subhod-i
approved these changes
Oct 17, 2023
Collaborator
subhod-i
left a comment
subhod-i
left a comment
There was a problem hiding this comment.
After from fthe comments the code changes look good to me.
Comment on lines
+45
to
+53
| handleUnknownError(error); | ||
| setTimeout(() => { | ||
| this.handleWebsocketOpen(); | ||
| }, WEB_SOCKET_RECONNECT_TIMEOUT); | ||
| } |
Collaborator
There was a problem hiding this comment.
Maybe introduce a maximum tries check here to avoid the infinite loop when there is no internet
davidyuk
reviewed
Nov 3, 2023
Member
davidyuk
left a comment
davidyuk
left a comment
There was a problem hiding this comment.
There is a code for the same goal in sdk repo https://github.com/aeternity/aepp-sdk-js/blob/develop/src/MiddlewareSubscriber.ts (already released)
Though it has own issues
| NETWORK_MAINNET, | ||
| } from '../popup/utils'; | ||
|
|
||
| class WebSocketClient { |
Member
There was a problem hiding this comment.
I would add middleware to the name because it is aware of it
CedrikNikita
force-pushed
the
features/websocket
branch
from
1267808 to
5dc7e73
Compare
|
Deployed to features-websocket.wallet.z52da5wt.xyz, artifacts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.