[496] Features: Push notification, Incoming Transaction, Websockets by ifaouibadi · Pull Request #1739 · superhero-com/superhero-wallet

ifaouibadi · 2022-12-14T09:31:08Z

No description provided.

github-actions · 2022-12-14T09:38:07Z

Deployed to features-push-notification.wallet.z52da5wt.xyz, artifacts

src/composables/incomingTransactions.ts

src/composables/websocket.ts

package.json

src/composables/incomingTransactions.ts

subhod-i · 2023-05-04T08:33:14Z

I remember @thepiwo once said we will introduce a web socket for multisig backend too to detect new multisig vaults.
@ifaouibadi Please take this into consideration we should be able to use WebsocketClient.ts file even for other web socket connections.

src/lib/webSocketClient.ts

thepiwo · 2023-05-04T12:06:19Z

I started work on websockets for the ga-multisig backend, but we never followed up with an actual plan on integration, so I abandoned the approach for the time aeternity/ga-multisig-backend@515b598

let's have a meeting to pick it up again

subhod-i · 2023-05-04T17:11:22Z

I started work on websockets for the ga-multisig backend, but we never followed up with an actual plan on integration, so I abandoned the approach for the time aeternity/ga-multisig-backend@515b598

let's have a meeting to pick it up again

This is important to optimize the performance of the SH wallet, especially to eliminate polling to the multisig backend. Let's talk soon ✌️

src/composables/composablesHelpers.ts

ifaouibadi · 2023-05-08T17:15:40Z

Although the WebSocket methods are static it looks like there are many parallel connections that keep on getting added as we switch networks. If you observe the notifications are still received from the first connection made. Here is the screenshot

Improved network unsubscribe from previous when it's been changed

Notifications are received only from the active network. I believe notifications should be network agnostic with each notification indicating the network.

it's not a good idea to listen for all networks been added in the app as it can cause notifications duplicate or receiving unexpected notification from non active network

@subhod-i

subhod-i · 2023-05-09T07:13:07Z

it's not a good idea to listen for all networks been added in the app as it can cause notifications duplicate or receiving unexpected notification from non active network

Fine.

src/background/popupHandler.ts

src/popup/pages/NetworkForm.vue

src/composables/composablesHelpers.ts

CedrikNikita · 2023-06-02T11:02:01Z

I suggest to add a redirect from transaction notification to open details of this transaction .

src/lib/pushNotification.ts

src/lib/webSocketClient.ts

src/composables/composablesHelpers.ts

src/popup/utils/constants.ts

src/types/index.ts

src/lib/webSocketClient.ts

src/popup/utils/constants.ts

src/popup/components/NotificationItem.vue

src/lib/WebSocketClient.ts

peronczyk · 2023-06-14T07:35:48Z

src/popup/utils/constants.ts

This is actually not an channel name. Also Object is already used in the IMiddlewareWebSocketSubscriptionMessage payload prop.

it's a channel name :D https://github.com/aeternity/ae_mdw#publishing-message-format

used to subscribe for specific address

src/popup/App.vue

peronczyk · 2023-06-14T09:24:38Z

src/composables/composablesHelpers.ts

Changes done in this file are not necessary as non of the files are using them.

subhod-i

We will have a re-review. Multiple updates

…ansactions

ifaouibadi marked this pull request as draft December 14, 2022 10:40

ifaouibadi force-pushed the features/push-notification branch 2 times, most recently from 59d59af to 1da6eac Compare January 9, 2023 12:03

github-advanced-security bot found potential problems Jan 10, 2023

View reviewed changes

src/composables/incomingTransactions.ts Fixed Show fixed Hide fixed

src/composables/incomingTransactions.ts Fixed Show fixed Hide fixed

src/composables/incomingTransactions.ts Fixed Show fixed Hide fixed

ifaouibadi force-pushed the features/push-notification branch 4 times, most recently from 25a4750 to 935e243 Compare January 11, 2023 11:19

ifaouibadi marked this pull request as ready for review January 11, 2023 11:42

ifaouibadi changed the title ~~[496] Features/push notification~~ [496] Features: Push notification, Incoming Transaction, Websockets Jan 11, 2023

ifaouibadi requested review from CedrikNikita, konradodo, peronczyk, pstachel and subhod-i and removed request for peronczyk and pstachel January 11, 2023 11:54

ifaouibadi force-pushed the features/push-notification branch from 88e16c6 to 3ae242a Compare January 12, 2023 10:39