Open
Conversation
ifaouibadi
commented
Feb 6, 2024
vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/im/vector/app/features/home/room/detail/timeline/item/MergedRoomCreationItem.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/home/room/list/RoomSummaryCenteredItem.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/home/room/list/RoomSummaryItem.kt
Outdated
Show resolved
Hide resolved
venimus
reviewed
Feb 6, 2024
| it.replaceFirst("[TG] ", "") // Remove [TG] from the beginning | ||
| } | ||
| it.contains("$") -> { | ||
| it.replace("$", "") // Remove $ from the string |
Member
There was a problem hiding this comment.
I guess all these replacements should only change the first occurance as the name may contain multiple '$$$'
Member
There was a problem hiding this comment.
I think that block change is redundant anyway, there is another "replacement" again on the resulting string below
venimus
reviewed
Feb 6, 2024
vector/src/main/java/im/vector/app/features/home/room/list/RoomSummaryItem.kt
Outdated
Show resolved
Hide resolved
venimus
reviewed
Feb 6, 2024
| } | ||
| ?: VectorMatrixItemDisplayNameFallbackProvider.getDefaultName(this).replace("[TG] ","").replace("$","") | ||
|
|
||
| modifiedDisplayName.replace("[TG] ", "").replace("$","") |
Member
There was a problem hiding this comment.
[TG] name$ would lead to name instead of name$
venimus
reviewed
Feb 6, 2024
|
|
||
| holder.roomNameText.setTextOrHide(roomDisplayName) | ||
| if (roomSummary?.displayName!!.contains("[TG]")) { | ||
| holder.roomNameText.setTextOrHide(roomDisplayName!!.replace("[TG] ","")) |
Member
There was a problem hiding this comment.
roomDisplayName is already sanitized on line 176
ifaouibadi
force-pushed
the
features/tg-rooms
branch
from
5328a03 to
8e748fe
Compare
|
@ifaouibadi what's the status of this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.