Merged
Conversation
Fix bulk block sync
…mparable-fields fix: do not compare incomparable fields
refactor: add a soft fail in case there is no token found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches portfolio history lookups, MDW block/tx syncing, and token holder refresh flows; behavior changes (name resolution, retry scheduling, fail-fast on DB pool issues) could affect production indexing and background jobs if edge cases are missed.
Overview
Improves portfolio history lookups by resolving AENS-style names (e.g.
*.chain) to anak_pubkey before balance/PNL queries, with a safe fallback to the raw input when resolution fails.Adds structured database connectivity/pool issue logging via new
runWithDatabaseIssueLogginghelpers and applies it across historical price saves, MDW block/microblock/transaction syncing, and token-eligibility refresh; additionally updatesBlockSyncServiceto fail fast on connection/pool errors in bulk upsert instead of falling back torepository.save.Tightens token-related robustness:
SyncTokenHoldersQueuenow schedules delayed retries onRetryableTokenHoldersSyncError(emitted for contract-not-ready cases), token creation paths switch toupsertto reduce duplicate-key races, andGET :address/holdersnow returns 404 when the token is missing.Tweaks CoinGecko market caching by increasing the default soft-TTL for cached market data to 3 minutes (with tests added/updated).
Written by Cursor Bugbot for commit 3110c30. This will update automatically on new commits. Configure here.