-
Notifications
You must be signed in to change notification settings - Fork 0
Add Giphy API key for CI configuration #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f3c7567
chore(ci): add giphy api key
venimus 63bd481
Merge pull request #87 from superhero-com/main
CedrikNikita bd9a327
feat: implement batch processing for token PNL calculations and enhan…
ifaouibadi a016060
refactor: streamline performance logging and enhance block height res…
ifaouibadi a5eb989
feat: optimize transaction scanning with MATERIALIZED CTE for improve…
ifaouibadi 52bce07
refactor: remove performance logging and streamline price fetching in…
ifaouibadi d861b16
Merge pull request #88 from superhero-com/features/account-pnl-histor…
ifaouibadi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testnet deployment uses wrong secret prefix for Giphy key
Medium Severity
The
deploy_testnetjob referencessecrets.DEV_GIPHY_API_KEYinstead ofsecrets.TESTNET_GIPHY_API_KEY. Every other environment-specific secret in this job uses theTESTNET_prefix (e.g.,TESTNET_TRENDING_TAGS_API_KEY,TESTNET_X_CLIENT_ID), so this looks like a copy-paste error from thedeploy_mainnetjob above. This causes the testnet deployment to use the dev Giphy API key instead of its own.