-
Notifications
You must be signed in to change notification settings - Fork 0
Release #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release #107
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
80e2eee
build: remove unused dependencies
CedrikNikita f21a7d9
build: run npm update
CedrikNikita c70b6b4
feat(accounts): implement getPortfolioPnlChart endpoint for SVG spark…
ifaouibadi 9b7bc07
feat(sparkline): add CSS color sanitization for SVG attributes to pre…
ifaouibadi bc4224f
feat(coin-gecko): refactor CoinGeckoService to improve data fetching …
ifaouibadi 34a47cc
refactor(coin-gecko): improve code readability by formatting function…
ifaouibadi a4bec60
refactor(coin-gecko): enhance getPriceData method to clarify rate war…
ifaouibadi 00ee79f
feat(coin-gecko): add hourly historical price synchronization and imp…
ifaouibadi 7c238ce
feat(accounts): add getTokensPnlHistory endpoint to retrieve token Pn…
ifaouibadi bd7837d
feat(accounts): enhance portfolio history endpoints with detailed sum…
ifaouibadi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated interval/date parsing logic across two controller methods
Low Severity
getTokensPnlHistoryduplicates the date-parsing, interval-clamping, andinclude-field splitting logic fromgetPortfolioHistory. If the interval calculation or date handling changes in one method but not the other, responses from the two endpoints will silently diverge. Extracting the shared query-to-options mapping into a private helper would keep both endpoints consistent.Additional Locations (1)
src/account/controllers/accounts.controller.ts#L175-L206