feat: footnotes render #1686
feat: footnotes render #1686
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 679262ffc0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }; | ||
| const w = sectionPageSize.w - (sectionMargins.left + sectionMargins.right); |
There was a problem hiding this comment.
This chooses the maximum content width across all sections to measure footnote blocks, so any footnote that lands on a narrower section will be measured too wide and therefore too short. The reserved height is then underestimated, which can push footnote fragments into the footer/body overlap zone on pages with smaller margins or page sizes. This shows up in multi‑section documents where later sections are narrower. Consider measuring/reserving per page (or at least using the minimum content width) so the reserved height reflects the actual page width where the footnote renders.
Useful? React with 👍 / 👎.
VladaHarbour
force-pushed
the
sd-963_footnotes
branch
from
679262f to
335d90b
Compare
No description provided.