feat: add page count to vanilla example #1657
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 81c48eb01e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| setTimeout(() => { | ||
| const documents = editor.superdocStore.documents; | ||
| const presentationEditor = documents[0]?.getPresentationEditor(); | ||
|
|
||
| if (presentationEditor) { |
There was a problem hiding this comment.
The onEditorCreate callback runs as soon as the editor instance is created, but document initialization in superdocStore.init is async (it awaits file/URL loading). With the fixed setTimeout(100) here, editor.superdocStore.documents can still be empty for larger files or remote URLs, so presentationEditor stays undefined and the page count is never displayed. This shows up when users load a real document via the file picker: the UI stays blank even though the document eventually renders. Consider waiting for a document-ready signal (e.g., a store-ready flag/event) or recomputing when pages become available rather than using a hard-coded delay.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Please assess if this is relevant or not
|
@caio-pizzol Could I get your review on this when you get a chance? This adds page count to the vanilla SuperDoc example. |
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
Let's respond to codex comment + example deploy (do we actually need to deploy it?)
| setTimeout(() => { | ||
| const documents = editor.superdocStore.documents; | ||
| const presentationEditor = documents[0]?.getPresentationEditor(); | ||
|
|
||
| if (presentationEditor) { |
There was a problem hiding this comment.
Please assess if this is relevant or not
| @@ -0,0 +1,21 @@ | |||
| name = "superdoc-page-count" | |||
There was a problem hiding this comment.
Why cloudflare pages? :)
I thought we agreed on Github pages instead
| "superdoc": "1.2.1" | ||
| }, | ||
| "devDependencies": { | ||
| "vite": "^4.4.6" |
There was a problem hiding this comment.
Let's update devDeps as well
npx npm-check-updates -u
No description provided.