Demo e2e annotations #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a custom signature component using `signature_pad` for drawing signatures. - Updated the demo to include document field definitions and improved event logging. - Integrated API calls for document annotation and signing, utilizing the provided API key. - Enhanced the Vite configuration for better development experience and added a README for setup instructions. - Included new dependencies in `package.json` and updated the lock file accordingly.
caio-pizzol
reviewed
Dec 17, 2025
Contributor
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
Looking good!
Main concerns are API key security and demo project structure
…oyment - Changed the proxy target in Vite config to point to localhost for local testing. - Removed the custom signature component and replaced it with a simpler implementation. - Introduced a helper function to download response blobs as files. - Refactored API calls in the App component to streamline document signing and downloading processes.
Collaborator
Author
|
@caio-pizzol nice comments! Fixed all of them |
caio-pizzol
reviewed
Dec 22, 2025
Contributor
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
Looking good!!
Just some small tweaks
caio-pizzol
deleted the
andrii/sd-1182-create-demo-of-e-sign-component-e2e
branch
|
🎉 This PR is included in version 1.4.0-next.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.