improved signing experience and fixed annotations logic #14
Conversation
- Updated the `normalizeFields` function to accept a `signatureMode` parameter for better handling of signature types. - Introduced a new utility function `textToImageDataUrl` to convert typed signatures into PNG data URLs. - Refactored the App component to utilize the new signature handling logic, including mapping signer fields based on type. - Added unit tests for the `textToImageDataUrl` function to ensure correct functionality. - Improved the demo to include a configuration for signer fields and updated API calls for signing and downloading documents.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
The signature handling improvements look solid, but I'm concerned about demo complexity.
We're adding ~100 lines of signature processing logic (SVG cropping, PNG conversion, canvas resizing) to what should be a minimal integration example.
Or... if we really want to build a full end2end demo app - maybe that should live outside of the esign component repo
|
Let's make sure the Document Fields panel is mobile responsive (move it below editor) 
|
@caio-pizzol nice comment! fixed |
caio-pizzol
deleted the
andrii/sd-1304-feedback-fix-e-sign-demo-signature-moments
branch
|
🎉 This PR is included in version 1.4.0-next.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
normalizeFieldsfunction to accept asignatureModeparameter for better handling of signature types (annotation - only images, sign - real signature wrapper).textToImageDataUrlto convert typed signatures into PNG data URLs.