Skip to content

Conversation

@paridhimalviya
Copy link

Array-2

Problem1 (https://leetcode.com/problems/find-all-numbers-disappeared-in-an-array/)

Problem2

Given an array of numbers of length N, find both the minimum and maximum. Follow up : Can you do it using less than 2 * (N - 2) comparison

Problem3 (https://leetcode.com/problems/game-of-life/)

@paridhimalviya paridhimalviya changed the title Find disappeared numbers. Game of life. Find min and max in array by … Complete Array-2 Jan 12, 2026
@super30admin
Copy link
Owner

  • Strengths:
    • The student demonstrates a strong understanding of in-place algorithms and efficient problem-solving techniques.
    • The code is well-commented and easy to follow.
    • The solutions are optimized for both time and space complexity.
  • Areas for Improvement:
    • In "FindDisappearedNumbers", the function name findDisappearedNumber is singular, which might be misleading since it returns an array of numbers. Consider renaming it to findDisappearedNumbers for clarity.
    • In "GameOfLife", the function countLiveCellsAround could be made more efficient by avoiding redundant checks, though the current implementation is correct.
    • In "MinAndMaxInArray", the function findMinAndMaxByReducingComparisons could handle the case where the array length is odd, though the current implementation works for even lengths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants