Open
Conversation
mattrossman
reviewed
Mar 24, 2026
| name: z.string(), | ||
| name: z.string().refine( | ||
| (filePath) => { | ||
| const resolved = path.resolve(process.cwd(), filePath); |
Contributor
There was a problem hiding this comment.
This looks off to me—in this context, name represents the path within the edge function bundle where the function will be written, not a file path on the machine running the MCP process. Why would process.cwd() be a factor? I might need to see a test case showing what sort of scenario this prevents to better understand the motivation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
chore
What is the current behavior?
mcp server has lax local path name acceptance
What is the new behavior?
enforces paths to be in the current working directory