chore(splinter): integrate runtime

crates/pgls_analyser/src/lib.rs

@@ -23,7 +23,6 @@ pub use linter_rule::{LinterDiagnostic, LinterRule};
 pub use LinterDiagnostic as RuleDiagnostic;
 pub use LinterRule as Rule;
 pub use LinterRuleContext as RuleContext;
-
 pub static METADATA: LazyLock<MetadataRegistry> = LazyLock::new(|| {
     let mut metadata = MetadataRegistry::default();
     // Use a separate visitor for metadata that implements pgls_analyse::RegistryVisitor

crates/pgls_analyser/src/lint/safety/add_serial_column.rs

@@ -1,4 +1,4 @@
-use crate::{Rule, RuleContext, RuleDiagnostic};
+use crate::{LinterDiagnostic, LinterRule, LinterRuleContext};
 use pgls_analyse::{RuleSource, declare_lint_rule};
 use pgls_console::markup;
 use pgls_diagnostics::Severity;
@@ -38,10 +38,10 @@ declare_lint_rule! {
     }
 }
 
-impl Rule for AddSerialColumn {
+impl LinterRule for AddSerialColumn {
     type Options = ();
 
-    fn run(ctx: &RuleContext<Self>) -> Vec<RuleDiagnostic> {
+    fn run(ctx: &LinterRuleContext<Self>) -> Vec<LinterDiagnostic> {
         let mut diagnostics = Vec::new();
 
         if let pgls_query::NodeEnum::AlterTableStmt(stmt) = &ctx.stmt() {
@@ -56,7 +56,7 @@ impl Rule for AddSerialColumn {
                                 let type_str = get_type_name(type_name);
                                 if is_serial_type(&type_str) {
                                     diagnostics.push(
-                                        RuleDiagnostic::new(
+                                        LinterDiagnostic::new(
                                             rule_category!(),
                                             None,
                                             markup! {
@@ -86,7 +86,7 @@ impl Rule for AddSerialColumn {
 
                             if has_stored_generated {
                                 diagnostics.push(
-                                    RuleDiagnostic::new(
+                                    LinterDiagnostic::new(
                                         rule_category!(),
                                         None,
                                         markup! {

crates/pgls_analyser/src/lint/safety/adding_field_with_default.rs

@@ -1,4 +1,4 @@
-use crate::{Rule, RuleContext, RuleDiagnostic};
+use crate::{LinterDiagnostic, LinterRule, LinterRuleContext};
 use pgls_analyse::{RuleSource, declare_lint_rule};
 use pgls_console::markup;
 use pgls_diagnostics::Severity;
@@ -39,10 +39,10 @@ declare_lint_rule! {
     }
 }
 
-impl Rule for AddingFieldWithDefault {
+impl LinterRule for AddingFieldWithDefault {
     type Options = ();
 
-    fn run(ctx: &RuleContext<Self>) -> Vec<RuleDiagnostic> {
+    fn run(ctx: &LinterRuleContext<Self>) -> Vec<LinterDiagnostic> {
         let mut diagnostics = Vec::new();
 
         // Check PostgreSQL version - in 11+, non-volatile defaults are safe
@@ -75,7 +75,7 @@ impl Rule for AddingFieldWithDefault {
 
                             if has_generated {
                                 diagnostics.push(
-                                    RuleDiagnostic::new(
+                                    LinterDiagnostic::new(
                                         rule_category!(),
                                         None,
                                         markup! {
@@ -102,7 +102,7 @@ impl Rule for AddingFieldWithDefault {
 
                                     if !is_safe_default {
                                         diagnostics.push(
-                                            RuleDiagnostic::new(
+                                            LinterDiagnostic::new(
                                                 rule_category!(),
                                                 None,
                                                 markup! {
@@ -116,7 +116,7 @@ impl Rule for AddingFieldWithDefault {
                                 } else {
                                     // Pre PG 11, all defaults cause rewrites
                                     diagnostics.push(
-                                        RuleDiagnostic::new(
+                                        LinterDiagnostic::new(
                                             rule_category!(),
                                             None,
                                             markup! {

crates/pgls_analyser/src/lint/safety/adding_foreign_key_constraint.rs

@@ -1,4 +1,4 @@
-use crate::{Rule, RuleContext, RuleDiagnostic};
+use crate::{LinterDiagnostic, LinterRule, LinterRuleContext};
 use pgls_analyse::{RuleSource, declare_lint_rule};
 use pgls_console::markup;
 use pgls_diagnostics::Severity;
@@ -43,10 +43,10 @@ declare_lint_rule! {
     }
 }
 
-impl Rule for AddingForeignKeyConstraint {
+impl LinterRule for AddingForeignKeyConstraint {
     type Options = ();
 
-    fn run(ctx: &RuleContext<Self>) -> Vec<RuleDiagnostic> {
+    fn run(ctx: &LinterRuleContext<Self>) -> Vec<LinterDiagnostic> {
         let mut diagnostics = Vec::new();
 
         if let pgls_query::NodeEnum::AlterTableStmt(stmt) = &ctx.stmt() {
@@ -95,7 +95,7 @@ impl Rule for AddingForeignKeyConstraint {
 fn check_foreign_key_constraint(
     constraint: &pgls_query::protobuf::Constraint,
     is_column_constraint: bool,
-) -> Option<RuleDiagnostic> {
+) -> Option<LinterDiagnostic> {
     // Only check foreign key constraints
     if constraint.contype() != pgls_query::protobuf::ConstrType::ConstrForeign {
         return None;
@@ -121,7 +121,7 @@ fn check_foreign_key_constraint(
     };
 
     Some(
-        RuleDiagnostic::new(rule_category!(), None, markup! { {message} })
+        LinterDiagnostic::new(rule_category!(), None, markup! { {message} })
             .detail(None, detail)
             .note(note),
     )

crates/pgls_analyser/src/lint/safety/adding_not_null_field.rs

@@ -1,4 +1,4 @@
-use crate::{Rule, RuleContext, RuleDiagnostic};
+use crate::{LinterDiagnostic, LinterRule, LinterRuleContext};
 use pgls_analyse::{RuleSource, declare_lint_rule};
 use pgls_console::markup;
 use pgls_diagnostics::Severity;
@@ -42,10 +42,10 @@ declare_lint_rule! {
     }
 }
 
-impl Rule for AddingNotNullField {
+impl LinterRule for AddingNotNullField {
     type Options = ();
 
-    fn run(ctx: &RuleContext<Self>) -> Vec<RuleDiagnostic> {
+    fn run(ctx: &LinterRuleContext<Self>) -> Vec<LinterDiagnostic> {
         let mut diagnostics = Vec::new();
 
         // In Postgres 11+, this is less of a concern
@@ -60,7 +60,7 @@ impl Rule for AddingNotNullField {
             for cmd in &stmt.cmds {
                 if let Some(pgls_query::NodeEnum::AlterTableCmd(cmd)) = &cmd.node {
                     if cmd.subtype() == pgls_query::protobuf::AlterTableType::AtSetNotNull {
-                        diagnostics.push(RuleDiagnostic::new(
+                        diagnostics.push(LinterDiagnostic::new(
                             rule_category!(),
                             None,
                             markup! {

crates/pgls_analyser/src/lint/safety/adding_primary_key_constraint.rs

@@ -1,4 +1,4 @@
-use crate::{Rule, RuleContext, RuleDiagnostic};
+use crate::{LinterDiagnostic, LinterRule, LinterRuleContext};
 use pgls_analyse::{RuleSource, declare_lint_rule};
 use pgls_console::markup;
 use pgls_diagnostics::Severity;
@@ -40,10 +40,10 @@ declare_lint_rule! {
     }
 }
 
-impl Rule for AddingPrimaryKeyConstraint {
+impl LinterRule for AddingPrimaryKeyConstraint {
     type Options = ();
 
-    fn run(ctx: &RuleContext<Self>) -> Vec<RuleDiagnostic> {
+    fn run(ctx: &LinterRuleContext<Self>) -> Vec<LinterDiagnostic> {
         let mut diagnostics = Vec::new();
 
         if let pgls_query::NodeEnum::AlterTableStmt(stmt) = &ctx.stmt() {
@@ -92,12 +92,12 @@ impl Rule for AddingPrimaryKeyConstraint {
 
 fn check_for_primary_key_constraint(
     constraint: &pgls_query::protobuf::Constraint,
-) -> Option<RuleDiagnostic> {
+) -> Option<LinterDiagnostic> {
     if constraint.contype() == pgls_query::protobuf::ConstrType::ConstrPrimary
         && constraint.indexname.is_empty()
     {
         Some(
-            RuleDiagnostic::new(
+            LinterDiagnostic::new(
                 rule_category!(),
                 None,
                 markup! {

crates/pgls_analyser/src/lint/safety/adding_required_field.rs

@@ -1,4 +1,4 @@
-use crate::{Rule, RuleContext, RuleDiagnostic};
+use crate::{LinterDiagnostic, LinterRule, LinterRuleContext};
 use pgls_analyse::{RuleSource, declare_lint_rule};
 use pgls_console::markup;
 use pgls_diagnostics::Severity;
@@ -25,10 +25,10 @@ declare_lint_rule! {
     }
 }
 
-impl Rule for AddingRequiredField {
+impl LinterRule for AddingRequiredField {
     type Options = ();
 
-    fn run(ctx: &RuleContext<Self>) -> Vec<RuleDiagnostic> {
+    fn run(ctx: &LinterRuleContext<Self>) -> Vec<LinterDiagnostic> {
         let mut diagnostics = vec![];
 
         if let pgls_query::NodeEnum::AlterTableStmt(stmt) = ctx.stmt() {
@@ -47,7 +47,7 @@ impl Rule for AddingRequiredField {
                         == pgls_query::protobuf::AlterTableType::AtAddColumn
                     {
                         diagnostics.push(
-                            RuleDiagnostic::new(
+                            LinterDiagnostic::new(
                                 rule_category!(),
                                 None,
                                 markup! {

crates/pgls_analyser/src/lint/safety/ban_char_field.rs

@@ -1,4 +1,4 @@
-use crate::{Rule, RuleContext, RuleDiagnostic};
+use crate::{LinterDiagnostic, LinterRule, LinterRuleContext};
 use pgls_analyse::{RuleSource, declare_lint_rule};
 use pgls_console::markup;
 use pgls_diagnostics::Severity;
@@ -41,10 +41,10 @@ declare_lint_rule! {
     }
 }
 
-impl Rule for BanCharField {
+impl LinterRule for BanCharField {
     type Options = ();
 
-    fn run(ctx: &RuleContext<Self>) -> Vec<RuleDiagnostic> {
+    fn run(ctx: &LinterRuleContext<Self>) -> Vec<LinterDiagnostic> {
         let mut diagnostics = Vec::new();
 
         if let pgls_query::NodeEnum::CreateStmt(stmt) = &ctx.stmt() {
@@ -78,7 +78,9 @@ impl Rule for BanCharField {
     }
 }
 
-fn check_column_for_char_type(col_def: &pgls_query::protobuf::ColumnDef) -> Option<RuleDiagnostic> {
+fn check_column_for_char_type(
+    col_def: &pgls_query::protobuf::ColumnDef,
+) -> Option<LinterDiagnostic> {
     if let Some(type_name) = &col_def.type_name {
         for name_node in &type_name.names {
             if let Some(pgls_query::NodeEnum::String(name)) = &name_node.node {
@@ -87,7 +89,7 @@ fn check_column_for_char_type(col_def: &pgls_query::protobuf::ColumnDef) -> Opti
                 let type_str = name.sval.to_lowercase();
                 if type_str == "bpchar" || type_str == "char" || type_str == "character" {
                     return Some(
-                        RuleDiagnostic::new(
+                        LinterDiagnostic::new(
                             rule_category!(),
                             None,
                             markup! {

crates/pgls_analyser/src/lint/safety/ban_concurrent_index_creation_in_transaction.rs

@@ -1,4 +1,4 @@
-use crate::{Rule, RuleContext, RuleDiagnostic};
+use crate::{LinterDiagnostic, LinterRule, LinterRuleContext};
 use pgls_analyse::{RuleSource, declare_lint_rule};
 use pgls_console::markup;
 use pgls_diagnostics::Severity;
@@ -27,10 +27,10 @@ declare_lint_rule! {
     }
 }
 
-impl Rule for BanConcurrentIndexCreationInTransaction {
+impl LinterRule for BanConcurrentIndexCreationInTransaction {
     type Options = ();
 
-    fn run(ctx: &RuleContext<Self>) -> Vec<RuleDiagnostic> {
+    fn run(ctx: &LinterRuleContext<Self>) -> Vec<LinterDiagnostic> {
         let mut diagnostics = Vec::new();
 
         // check if the current statement is CREATE INDEX CONCURRENTLY and there is at least one
@@ -39,7 +39,7 @@ impl Rule for BanConcurrentIndexCreationInTransaction {
         // since our analyser assumes we're always in a transaction context, we always flag concurrent indexes
         if let pgls_query::NodeEnum::IndexStmt(stmt) = ctx.stmt() {
             if stmt.concurrent && ctx.file_context().stmt_count() > 1 {
-                diagnostics.push(RuleDiagnostic::new(
+                diagnostics.push(LinterDiagnostic::new(
                     rule_category!(),
                     None,
                     markup! {

crates/pgls_analyser/src/lint/safety/ban_drop_column.rs

@@ -1,4 +1,4 @@
-use crate::{Rule, RuleContext, RuleDiagnostic};
+use crate::{LinterDiagnostic, LinterRule, LinterRuleContext};
 use pgls_analyse::{RuleSource, declare_lint_rule};
 use pgls_console::markup;
 use pgls_diagnostics::Severity;
@@ -27,17 +27,17 @@ declare_lint_rule! {
     }
 }
 
-impl Rule for BanDropColumn {
+impl LinterRule for BanDropColumn {
     type Options = ();
 
-    fn run(ctx: &RuleContext<Self>) -> Vec<RuleDiagnostic> {
+    fn run(ctx: &LinterRuleContext<Self>) -> Vec<LinterDiagnostic> {
         let mut diagnostics = Vec::new();
 
         if let pgls_query::NodeEnum::AlterTableStmt(stmt) = &ctx.stmt() {
             for cmd in &stmt.cmds {
                 if let Some(pgls_query::NodeEnum::AlterTableCmd(cmd)) = &cmd.node {
                     if cmd.subtype() == pgls_query::protobuf::AlterTableType::AtDropColumn {
-                        diagnostics.push(RuleDiagnostic::new(
+                        diagnostics.push(LinterDiagnostic::new(
                             rule_category!(),
                             None,
                             markup! {

crates/pgls_analyser/src/lint/safety/ban_drop_database.rs

@@ -1,4 +1,4 @@
-use crate::{Rule, RuleContext, RuleDiagnostic};
+use crate::{LinterDiagnostic, LinterRule, LinterRuleContext};
 use pgls_analyse::{RuleSource, declare_lint_rule};
 use pgls_console::markup;
 use pgls_diagnostics::Severity;
@@ -16,15 +16,15 @@ declare_lint_rule! {
     }
 }
 
-impl Rule for BanDropDatabase {
+impl LinterRule for BanDropDatabase {
     type Options = ();
 
-    fn run(ctx: &RuleContext<Self>) -> Vec<RuleDiagnostic> {
+    fn run(ctx: &LinterRuleContext<Self>) -> Vec<LinterDiagnostic> {
         let mut diagnostics = vec![];
 
         if let pgls_query::NodeEnum::DropdbStmt(_) = &ctx.stmt() {
             diagnostics.push(
-                RuleDiagnostic::new(
+                LinterDiagnostic::new(
                     rule_category!(),
                     None,
                     markup! {

crates/pgls_analyser/src/lint/safety/ban_drop_not_null.rs

@@ -1,4 +1,4 @@
-use crate::{Rule, RuleContext, RuleDiagnostic};
+use crate::{LinterDiagnostic, LinterRule, LinterRuleContext};
 use pgls_analyse::{RuleSource, declare_lint_rule};
 use pgls_console::markup;
 use pgls_diagnostics::Severity;
@@ -27,17 +27,17 @@ declare_lint_rule! {
     }
 }
 
-impl Rule for BanDropNotNull {
+impl LinterRule for BanDropNotNull {
     type Options = ();
 
-    fn run(ctx: &RuleContext<Self>) -> Vec<RuleDiagnostic> {
+    fn run(ctx: &LinterRuleContext<Self>) -> Vec<LinterDiagnostic> {
         let mut diagnostics = Vec::new();
 
         if let pgls_query::NodeEnum::AlterTableStmt(stmt) = &ctx.stmt() {
             for cmd in &stmt.cmds {
                 if let Some(pgls_query::NodeEnum::AlterTableCmd(cmd)) = &cmd.node {
                     if cmd.subtype() == pgls_query::protobuf::AlterTableType::AtDropNotNull {
-                        diagnostics.push(RuleDiagnostic::new(
+                        diagnostics.push(LinterDiagnostic::new(
                             rule_category!(),
                             None,
                             markup! {