Skip to content

fix: use rules for deciding if deploy job should be started#165

Merged
tijsverkoyen merged 2 commits intomasterfrom
fix-for-auto-deploy
Jan 20, 2026
Merged

fix: use rules for deciding if deploy job should be started#165
tijsverkoyen merged 2 commits intomasterfrom
fix-for-auto-deploy

Conversation

@tijsverkoyen
Copy link
Member

@tijsverkoyen tijsverkoyen commented Jan 19, 2026

Summary by Sourcery

Build:

  • Replace only-based branch filters with rules for staging and production deploy jobs, ensuring they run only on their respective branches and are skipped for scheduled pipelines.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 19, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update GitLab CI deploy jobs to use rules-based conditions instead of only, preventing deploys from scheduled pipelines and limiting them to the appropriate branches.

Flow diagram for deploy job rules evaluation

flowchart TD
  Start([Pipeline_created]) --> Src{CI_PIPELINE_SOURCE}

  Src -->|schedule| Block[Do_not_run_deploy_jobs]
  Src -->|push_or_other| BranchCheck

  BranchCheck{CI_COMMIT_BRANCH}

  BranchCheck -->|staging| RunStaging[Run_Deploy_to_staging]
  BranchCheck -->|master| RunProd[Run_Deploy_to_production]
  BranchCheck -->|other| Skip[Skip_deploy_jobs]

  Block --> End([End])
  RunStaging --> End
  RunProd --> End
  Skip --> End
Loading

File-Level Changes

Change Details Files
Switch deploy-to-staging job from only to rules, blocking scheduled pipelines and allowing runs only on the staging branch.
  • Remove only: staging condition from the staging deploy job.
  • Add rules to skip the job when CI_PIPELINE_SOURCE is schedule.
  • Add rule to run the job when CI_COMMIT_BRANCH equals staging.
.gitlab-ci.yml
Switch deploy-to-production job from only to rules, blocking scheduled pipelines and allowing runs only on the master branch.
  • Remove only: master condition from the production deploy job.
  • Add rules to skip the job when CI_PIPELINE_SOURCE is schedule.
  • Add rule to run the job when CI_COMMIT_BRANCH equals master.
.gitlab-ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the GitLab CI configuration from the deprecated only keyword to the modern rules keyword for deployment jobs, while explicitly preventing deployments from running during scheduled pipelines.

Changes:

  • Replaced only keyword with rules for both staging and production deploy jobs
  • Added explicit exclusion of scheduled pipelines from deployment jobs
  • Maintained branch-based deployment triggers (staging and master branches)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tijsverkoyen tijsverkoyen merged commit 08f7fb5 into master Jan 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants