Open
Conversation
martinlagler
force-pushed
the
feature/settings-update-date
branch
9 times, most recently
from
9a4dcbb to
d177b73
Compare
martinlagler
force-pushed
the
feature/settings-update-date
branch
from
d177b73 to
48b3871
Compare
alexander-schranz
requested changes
Jul 3, 2024
| public function setAuthor(?ContactInterface $author): void; | ||
|
|
||
| public function getAuthored(): ?\DateTimeImmutable; | ||
| public function getAuthored(): ?\DateTime; |
Member
There was a problem hiding this comment.
we should always use DateTimeImmutable
composer.json
Outdated
| "doctrine/inflector": "^1.4.1 || ^2.0.1", | ||
| "doctrine/collections": "^1.0", | ||
| "doctrine/orm": "^2.5.3", | ||
| "doctrine/orm": "^2.5.3 || ^2.8", |
composer.json
Outdated
| "massive/search-bundle": "^2.4", | ||
| "ramsey/uuid": "^3.8 || ^4.0", | ||
| "sulu/sulu": "^2.4 || ^2.6@dev", | ||
| "sulu/sulu": "2.6.x-dev", |
Member
There was a problem hiding this comment.
we should avoid eventually required upgrade may we can bridge it
composer.json
Outdated
| "phpunit/phpunit": "^8.5.33 || ^9.6.5", | ||
| "qossmic/deptrac-shim": "^0.11.1 || ^0.23.0 || ^1.0", | ||
| "sulu/automation-bundle": "^2.0@dev", | ||
| "sulu/automation-bundle": "^2.0@dev || ^2.1", |
Member
There was a problem hiding this comment.
Suggested change
| "sulu/automation-bundle": "^2.0@dev || ^2.1", | |
| "sulu/automation-bundle": "^2.0 || ^2.1@dev", |
composer.json
Outdated
Comment on lines
69
to
70
| "doctrine/persistence": "1.3.2", | ||
| "doctrine/orm": "2.10.0 || 2.14.2 || >=2.16.0" |
Member
There was a problem hiding this comment.
Should not longer be required
Suggested change
| "doctrine/persistence": "1.3.2", | |
| "doctrine/orm": "2.10.0 || 2.14.2 || >=2.16.0" | |
| "doctrine/persistence": "1.3.2" |
martinlagler
force-pushed
the
feature/settings-update-date
branch
2 times, most recently
from
ceb6b97 to
aae511f
Compare
Pull Request Test Coverage Report for Build 12989957644Details
💛 - Coveralls |
martinlagler
force-pushed
the
feature/settings-update-date
branch
from
aae511f to
516b871
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.