Skip to content

fix: export aggregation bases#189

Open
kahoowkh wants to merge 1 commit intosudo-suhas:masterfrom
kahoowkh:fix-export-agg-base
Open

fix: export aggregation bases#189
kahoowkh wants to merge 1 commit intosudo-suhas:masterfrom
kahoowkh:fix-export-agg-base

Conversation

@kahoowkh
Copy link

@kahoowkh kahoowkh commented Nov 13, 2023

Hi @sudo-suhas,

I got the following error when I try to import MetricsAggregationBase and create a new class CustomAggregation extending it.

class CustomAggregation extends elastic_builder_1.MetricsAggregationBase {
                                                       ^

TypeError: Class extends value undefined is not a constructor or null

I noticed the type definitions of the aggregation bases are exported in index.d.ts but the actual classes are not exported in index.js. I exported them in this PR, so the above can be fixed.

Could you please have a look and let me know what you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant