feat: Add type option to queryStringQuery#153
feat: Add type option to queryStringQuery#153mccool wants to merge 2 commits intosudo-suhas:masterfrom
Conversation
| * `best_fields`. | ||
| * @returns {QueryStringQuery} returns `this` so that calls can be chained. | ||
| */ | ||
| type(type) { |
There was a problem hiding this comment.
Could you please update the type definition as well - https://github.com/sudo-suhas/elastic-builder/blob/v2.16.0/src/index.d.ts#L996-L1078
There was a problem hiding this comment.
Should we just have an enum for these type values? They are duplicated in the multi match query. Also in the .js files these values are duplicated. How do you want to handle this?
There was a problem hiding this comment.
Could you clarify what you mean by an enum? The source is not using Typescript yet.
They are duplicated in the multi-match query.
Yes, we could re-use MULTI_MATCH_TYPE defined in the src/core/consts.js file.
There was a problem hiding this comment.
I've been a bit busy but will get to this soon. I have also found 1 more area that I want to improve and will just include it with this PR since as well.
I'll get some changes pushed up next week to get this (hopefully) approved and released.
| * - `phrase_prefix` - Runs a `match_phrase_prefix` query on each field | ||
| * and combines the `_score` from each field. | ||
| * | ||
| * - `bool_prefix` - Creates a match_bool_prefix query on each field and |
There was a problem hiding this comment.
I think this type was not available in Elasticsearch v6 - https://www.elastic.co/guide/en/elasticsearch/reference/6.8/query-dsl-multi-match-query.html#multi-match-types
Could we add a note regarding the same? If you can identify the exact version that it was added in, that would be great.
| * `best_fields`. | ||
| * @returns {QueryStringQuery} returns `this` so that calls can be chained. | ||
| */ | ||
| type(type) { |
There was a problem hiding this comment.
As far as I can see, this option was added only in Elasticsearch v6 based on the docs for v5. Can we add a note calling out the same?
|
@mccool would you be able to work on the requested changes? |
|
@sudo-suhas I think I'll be able to get back to this in about a week or two. |
|
Thanks @mccool, that would be great. |
2 participants
Add the ability to pass in a type to the query string query. It can be used just all the other options available on the queryStringQuery
.type('most_fields')https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html#query-string-multi-field-parms