fix: await async gen() calls in media_seen#229
Closed
themavik wants to merge 1 commit intosubzeroid:mainfrom
Closed
fix: await async gen() calls in media_seen#229themavik wants to merge 1 commit intosubzeroid:mainfrom
themavik wants to merge 1 commit intosubzeroid:mainfrom
Conversation
gen() is an async function but was called without await, causing the coroutine objects to be passed directly into the request data dict. JSON serialization then fails with: TypeError: Object of type coroutine is not JSON serializable Add await to both gen() calls so the coroutines are resolved to dicts before being serialized. Fixes #116 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
media_seen()calls the innergen()coroutine function withoutawait, passing raw coroutine objects into the request data dict. When the dict is JSON-serialized, this raises:Changes
Add
awaitto bothgen()calls so the coroutines are resolved to dicts before serialization:Test Plan
await client.media_seen(["media_id"]): request is sent with properly serialized reels data instead of crashingawait client.story_seen([media_id]): no longer raises TypeErrorFixes #116