Skip to content

Verify ERB files with herb analyze #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koppen merged 2 commits into from
Feb 22, 2026
Merged

Verify ERB files with herb analyze #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57b8959
Lint ERB files with herb analyze
koppen Feb 22, 2026
cdeb96e
Work around Herb
koppen Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/erb.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,15 @@ jobs:
ruby-version: ['3.4']
steps:
- uses: actions/checkout@v4
- name: herb

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
bundler-cache: true # runs 'bundle install' and caches installed gems automatically

- name: herb linter
run: npx @herb-tools/linter app/components --no-color

- name: herb analyzer
run: bundle exec herb analyze app/components
Comment on lines +30 to +31
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bundle exec herb analyze command requires Ruby to be set up and gems to be installed, but this workflow is missing the Ruby setup step. The workflow will fail because bundler is not available.

Add a Ruby setup step before this command, similar to the pattern used in .github/workflows/ruby.yml. You need to add:

  • A step to set up Ruby using ruby/setup-ruby@v1
  • Configure bundler-cache: true to automatically run bundle install

Without these steps, the bundle exec command will fail because the Ruby environment and the herb gem won't be available.

Copilot uses AI. Check for mistakes.
12 changes: 6 additions & 6 deletions app/components/flowbite/toast/toast.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<div
class="<%= container_classes.join(" ") %>"
role="alert"
<%= options.map { |k, v| "#{k}=\"#{v}\"" }.join(" ").html_safe %>
>
<%= tag.div(
class: container_classes.join(" "),
role: "alert",
**options,
) do %>
<%= render Flowbite::Toast::Icon.new(style: style) %>

<div class="ms-3 text-sm font-normal"><%= message %></div>
Expand Down Expand Up @@ -37,4 +37,4 @@
</svg>
</button>
<% end %>
</div>
<% end %>