feat: Add Atbash Cipher Implementation

[subc0der]

Summary

• ✅ Implemented Atbash cipher with complete UI integration
• ✅ Added comprehensive input validation and error handling
• ✅ Included detailed educational comments and algorithm explanations
• ✅ Created development workflow with launch scripts and testing tools
• ✅ Updated project documentation and coding standards

Features Added

• Atbash Cipher Card: New cipher tool with cyberpunk styling matching existing design
• Reversible Algorithm: Proper A↔Z, B↔Y transformation preserving case and non-alphabetic characters
• Input Validation: Comprehensive checking with user-friendly error messages
• Educational Content: Detailed comments, console logging, and algorithm explanations
• Development Tools: Launch scripts, npm commands, and testing utilities

Technical Details

• Follows established patterns from Caesar and Vigenère ciphers
• Implements proper error handling with try-catch blocks
• Uses mathematical formulas for character transformation
• Maintains cyberpunk theme with cyan/orange color scheme
• Includes comprehensive JSDoc documentation

Test Plan

• Manual testing with various input types (uppercase, lowercase, mixed, special characters)
• Reversibility testing (encode/decode returns original text)
• Input validation testing (empty inputs, whitespace, long text)
• UI integration testing (button clicks, output display)
• Cross-case testing (A↔Z, a↔z transformations)
• Edge case testing (numbers, punctuation, spaces preserved)

Development Workflow

• Added launch.bat and launch.ps1 for easy app testing
• Updated npm scripts for development and testing
• Created comprehensive test files for validation
• Established coding standards and Copilot guidelines

🤖 Generated with Claude Code

[Copilot]

Pull Request Overview

This PR adds a comprehensive Atbash cipher implementation to the SubCoder Cipher Matrix project with complete UI integration, testing infrastructure, and development workflow improvements. The implementation follows established patterns from existing ciphers while maintaining high code quality standards.

• Implements Atbash cipher with reversible A↔Z, B↔Y transformations preserving case and non-alphabetic characters
• Adds comprehensive testing tools including Node.js and browser-based test suites
• Enhances development workflow with launch scripts and improved npm commands

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/ciphers/atbash.js	Shared Atbash cipher implementation module with dual Node.js/browser compatibility
src/index.html	Updated main application with Atbash cipher UI integration and enhanced defensive programming
test-atbash.js	Node.js test script with comprehensive test cases and colorized terminal output
test-atbash.html	Browser-based test page for visual validation of Atbash cipher functionality
package.json	Enhanced npm scripts for development and testing workflows
main.js	Updated Electron app to load from new src directory structure
launch.ps1	PowerShell launcher script for easy browser-based testing
launch.bat	Batch launcher script for Electron app development
.claude/*.md	Project documentation and coding standards for development guidelines

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The console.log statements should be removed or replaced with a proper logging system. Even in development mode, using console.log for application startup messages is not a best practice. Consider using a proper logger or removing these statements entirely.

Suggested change

	console.log('🔐 SUBCODER CIPHER MATRIX LOADED 🔐');
	console.log('Welcome to the Subcoder Cipher Matrix! All encryption systems online.');

[Copilot]

Using regex with match() for simple character classification is inefficient. Replace with direct character code comparisons for better performance: (charCode >= 65 && charCode <= 90) || (charCode >= 97 && charCode <= 122)

Suggested change

	// Check if the character is a letter using regex
	if (char.match(/[a-z]/i)) {
	const charCode = char.charCodeAt(0);
	if (char >= 'A' && char <= 'Z') {
	// Uppercase letter transformation
	// A (65) becomes Z (90), B (66) becomes Y (89), etc.
	// Formula: 90 - (charCode - 65) = 155 - charCode
	return String.fromCharCode(
	CIPHER_CONSTANTS.UPPERCASE_Z_CODE - (charCode - CIPHER_CONSTANTS.UPPERCASE_A_CODE)
	);
	} else if (char >= 'a' && char <= 'z') {
	// Check if the character is a letter using character code comparison
	const charCode = char.charCodeAt(0);
	if (
	(charCode >= CIPHER_CONSTANTS.UPPERCASE_A_CODE && charCode <= CIPHER_CONSTANTS.UPPERCASE_Z_CODE) ||
	(charCode >= CIPHER_CONSTANTS.LOWERCASE_A_CODE && charCode <= CIPHER_CONSTANTS.LOWERCASE_Z_CODE)
	) {
	if (charCode >= CIPHER_CONSTANTS.UPPERCASE_A_CODE && charCode <= CIPHER_CONSTANTS.UPPERCASE_Z_CODE) {
	// Uppercase letter transformation
	// A (65) becomes Z (90), B (66) becomes Y (89), etc.
	// Formula: 90 - (charCode - 65) = 155 - charCode
	return String.fromCharCode(
	CIPHER_CONSTANTS.UPPERCASE_Z_CODE - (charCode - CIPHER_CONSTANTS.UPPERCASE_A_CODE)
	);
	} else if (charCode >= CIPHER_CONSTANTS.LOWERCASE_A_CODE && charCode <= CIPHER_CONSTANTS.LOWERCASE_Z_CODE) {

[Copilot]

The development mode detection is duplicated across multiple functions. This should be extracted to a constant or utility function that's defined once and reused throughout the application.

[Copilot]

This input length validation is duplicated in multiple cipher functions. Consider extracting this to a shared validation utility function to eliminate code duplication.

Suggested change

	// Comprehensive input validation
	if (!text) {
	showError('Please enter some text to encode/decode.');
	return;
	}
	if (!text.trim()) {
	showError('Input cannot be only whitespace. Please enter valid text.');
	return;
	}
	// Check for extremely long input that might cause performance issues
	if (text.length > APP_CONSTANTS.MAX_INPUT_LENGTH) {
	showError(`Input exceeds maximum length of ${APP_CONSTANTS.MAX_INPUT_LENGTH} characters. Current length: ${text.length}`);
	return;
	}
	// Use shared Atbash input validation utility
	const validationResult = window.AtbashCipher.isValidAtbashInput(text, APP_CONSTANTS.MAX_INPUT_LENGTH);
	if (validationResult !== true) {
	showError(validationResult || 'Invalid input for Atbash cipher.');
	return;
	}