fixed test updates 2

Author: stuchain

src/cuepoint/update/update_manager.py

@@ -636,11 +636,15 @@ def _do_check(self) -> None:
                     pass
                 return
 
-            # Update channel if changed
-            channel = self.preferences.get_channel()
-            if self.checker.channel != channel:
+            # Update channel if changed (use effective channel: test builds must stay on test)
+            effective_channel = (
+                "test"
+                if is_test_version(self.current_version)
+                else self.preferences.get_channel()
+            )
+            if self.checker.channel != effective_channel:
                 self.checker = UpdateChecker(
-                    self.feed_url, self.current_version, channel
+                    self.feed_url, self.current_version, effective_channel
                 )
 
             # Check for updates

src/tests/unit/update/test_two_appcast_channels.py

@@ -10,6 +10,7 @@
 
 import tempfile
 from pathlib import Path
+from unittest.mock import patch
 
 import pytest
 
@@ -154,6 +155,34 @@ def test_test_with_suffix_unsigned(self):
 class TestTestToTestUpdateReturnsDownloadUrl:
     """Test build updating to newer test build gets a valid download_url (no 404 after publishing test releases)."""
 
+    def test_thread_path_keeps_test_channel_for_test_build(self):
+        """_do_check (thread path, used on Windows) must not overwrite test channel with preference.
+
+        Bug: channel was set from preferences.get_channel() so test builds fetched stable feed.
+        """
+        with tempfile.NamedTemporaryFile(suffix=".json", delete=False) as f:
+            prefs_path = f.name
+        try:
+            prefs = UpdatePreferences(preferences_file=Path(prefs_path))
+            prefs.set_channel(UpdatePreferences.CHANNEL_STABLE)
+            manager = UpdateManager(
+                current_version="0.0.1-test",
+                feed_url="https://example.com/updates",
+                preferences=prefs,
+            )
+            assert manager.checker.channel == "test"
+            feed_url_before = manager.checker.get_feed_url("windows")
+            assert "/test/" in feed_url_before
+
+            with patch.object(manager.checker, "check_for_updates", return_value=None):
+                manager._do_check()
+
+            assert manager.checker.channel == "test"
+            feed_url_after = manager.checker.get_feed_url("windows")
+            assert "/test/" in feed_url_after
+        finally:
+            Path(prefs_path).unlink(missing_ok=True)
+
     def test_test_version_sees_newer_test_in_appcast_with_download_url(self):
         """0.0.3-test sees 0.0.4-test in appcast and gets update with HTTPS download_url."""
         # Minimal appcast with one item: 0.0.4-test, GitHub-style enclosure URL