fixed test updates

Author: stuchain

.github/workflows/release.yml

@@ -216,8 +216,9 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           GITHUB_REPOSITORY: ${{ github.repository }}
 
-      # Test tags (e.g. v1.0.3-test1.1) create a draft release: hidden from public
-      # Releases list; only visible to maintainers at GitHub Releases when logged in.
+      # All tags create a published release. Test tags (e.g. v1.0.3-test1.1) are
+      # marked prerelease so assets are public (no 404); website uses releases/latest
+      # which returns only non-prerelease, so it points to stable only.
       - name: Create GitHub Release
         uses: softprops/action-gh-release@v1
         with:
@@ -229,7 +230,7 @@ jobs:
             THIRD_PARTY_LICENSES.txt
             SHA256SUMS
           body_path: RELEASE_NOTES.md
-          draft: ${{ contains(github.ref_name, '-test') }}
+          draft: false
           prerelease: ${{ contains(github.ref_name, '-test') }}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

docs/release/design-two-appcast-feeds-test-stable.md

@@ -44,10 +44,11 @@
 | FR4 | Test tags do not run appcast generation. | Add workflow branch for test tag: generate and publish only `updates/*/test/` appcasts. |
 | I3, I4 | Not explicitly enforced; workflow only has one appcast path (stable). | Enforce by: (1) stable steps run only on non-test tag; (2) new test steps run only on test tag; (3) test publish does not pass `--index`. |
 
-### 1.5 Test releases remain drafts (no change)
+### 1.5 Test releases: published + prerelease (in-app update works)
 
-- **GitHub Release creation** in the release workflow **does not change**: test tags continue to create **draft** (and prerelease) releases; normal tags create published releases.
-- **Rationale:** Draft test releases stay hidden from the public Releases list and from `releases/latest`. The **only** addition is the **test appcast feed** on gh-pages, so that test builds can discover updates in-app. The website and “latest” behavior remain unchanged; test releases are still not offered for download on the site.
+- **GitHub Release creation:** Test tags create **published** releases with `prerelease: true` (not draft). This makes release assets publicly downloadable so in-app update (e.g. 0.0.3-test → 0.0.4-test) does not get 404.
+- **Website:** The site uses `releases/latest`, which returns the latest **non-prerelease** release, and the download page explicitly skips prereleases. So the website continues to offer only normal (stable) releases for download.
+- **Releases page:** Test builds appear in the GitHub Releases list with a Pre-release badge; they are visible but clearly marked.
 
 ---
 

gh-pages-root/index.html

@@ -302,10 +302,11 @@ <h2>Download</h2>
     (function () {
       var winEl = document.getElementById('win-dl');
       var macEl = document.getElementById('mac-dl');
+      // GitHub releases/latest returns the latest non-prerelease, non-draft release only.
       fetch('https://api.github.com/repos/stuchain/CuePoint/releases/latest')
         .then(function (r) { return r.json(); })
         .then(function (release) {
-          if (!release.assets || !release.assets.length) return;
+          if (release.prerelease || !release.assets || !release.assets.length) return;
           release.assets.forEach(function (asset) {
             var name = asset.name.toLowerCase();
             if (name.endsWith('.exe')) winEl.href = asset.browser_download_url;

src/cuepoint/utils/sentry_init.py

@@ -6,13 +6,16 @@
 
 Initializes the Sentry SDK when a DSN is available (env SENTRY_DSN or
 default below). Captures unhandled exceptions, ERROR/WARNING logs, and
-(when consent is given) sends them to Sentry. Use init_sentry_early()
-right after the crash handler so import-time and startup errors are also
-captured.
+(when consent is given) sends them to Sentry with full analytic context:
+stack traces, local variables, source context, breadcrumbs, and build/env
+tags. Use init_sentry_early() right after the crash handler so import-time
+and startup errors are also captured.
 """
 
 import logging
 import os
+import platform
+import sys
 from typing import Callable, Optional
 
 logger = logging.getLogger(__name__)
@@ -39,6 +42,30 @@ def _consent_allowed() -> bool:
         return False
 
 
+def _get_analytic_context() -> tuple[dict, dict]:
+    """Return (tags, extra) for full analytic context on every Sentry event."""
+    tags = {
+        "platform": platform.system(),
+        "platform_release": platform.release(),
+        "python_version": f"{sys.version_info.major}.{sys.version_info.minor}.{sys.version_info.micro}",
+        "machine": platform.machine(),
+        "frozen": str(getattr(sys, "frozen", False)),
+    }
+    extra = {}
+    try:
+        from cuepoint.version import get_build_info
+
+        build_info = get_build_info()
+        extra["build"] = build_info
+        if build_info.get("commit_sha"):
+            tags["commit_sha"] = build_info.get("short_commit_sha") or build_info.get("commit_sha", "")[:8]
+        if build_info.get("build_number"):
+            tags["build_number"] = str(build_info["build_number"])
+    except Exception:
+        pass
+    return tags, extra
+
+
 def init_sentry_early() -> bool:
     """Initialize Sentry as early as possible (call right after CrashHandler).
 
@@ -79,12 +106,24 @@ def init_sentry_early() -> bool:
     def before_send(event, hint):
         if not _consent_allowed():
             return None
+        tags, extra = _get_analytic_context()
+        if event.get("tags") is None:
+            event["tags"] = {}
+        event["tags"].update(tags)
+        if event.get("extra") is None:
+            event["extra"] = {}
+        event["extra"].update(extra)
         return event
 
     sentry_sdk.init(
         dsn=dsn,
         release=release,
         environment=env,
+        # Full analytic: attach stack traces to all events, local vars, source context
+        attach_stacktrace=True,
+        include_local_variables=True,
+        include_source_context=True,
+        max_breadcrumbs=200,
         traces_sample_rate=0.0,
         profiles_sample_rate=0.0,
         send_default_pii=False,
@@ -137,14 +176,30 @@ def init_sentry(
         level=logging.INFO,
         event_level=logging.WARNING,
     )
+
+    def before_send_with_context(event, hint):
+        tags, extra = _get_analytic_context()
+        if event.get("tags") is None:
+            event["tags"] = {}
+        event["tags"].update(tags)
+        if event.get("extra") is None:
+            event["extra"] = {}
+        event["extra"].update(extra)
+        return event
+
     sentry_sdk.init(
         dsn=dsn,
         release=release or get_version(),
         environment=env,
+        attach_stacktrace=True,
+        include_local_variables=True,
+        include_source_context=True,
+        max_breadcrumbs=200,
         traces_sample_rate=0.0,
         profiles_sample_rate=0.0,
         send_default_pii=False,
         integrations=[logging_integration],
+        before_send=before_send_with_context,
     )
     logger.info("Sentry error reporting initialized")
     return True

src/tests/unit/update/test_two_appcast_channels.py

@@ -148,3 +148,40 @@ def test_case_insensitive_test_prefix(self):
     def test_test_with_suffix_unsigned(self):
         """e.g. 1.0.0-test-unsigned42: prerelease starts with 'test'."""
         assert is_test_version("2.1.0-test-unsigned42") is True
+
+
+@pytest.mark.unit
+class TestTestToTestUpdateReturnsDownloadUrl:
+    """Test build updating to newer test build gets a valid download_url (no 404 after publishing test releases)."""
+
+    def test_test_version_sees_newer_test_in_appcast_with_download_url(self):
+        """0.0.3-test sees 0.0.4-test in appcast and gets update with HTTPS download_url."""
+        # Minimal appcast with one item: 0.0.4-test, GitHub-style enclosure URL
+        ns = "http://www.andymatuschak.org/xml-namespaces/sparkle"
+        appcast_xml = f"""<?xml version="1.0" encoding="UTF-8"?>
+<rss version="2.0" xmlns:sparkle="{ns}">
+  <channel>
+    <item>
+      <title>CuePoint 0.0.4-test</title>
+      <sparkle:version>202502111200</sparkle:version>
+      <sparkle:shortVersionString>0.0.4-test</sparkle:shortVersionString>
+      <enclosure url="https://github.com/stuchain/CuePoint/releases/download/v0.0.4-test/CuePoint-Setup-0.0.4-test.exe"
+                 length="50000000"
+                 type="application/octet-stream"
+                 sparkle:sha256="aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"/>
+    </item>
+  </channel>
+</rss>"""
+        checker = UpdateChecker(
+            feed_url="https://stuchain.github.io/CuePoint/updates",
+            current_version="0.0.3-test",
+            channel="test",
+        )
+        result = checker.check_update_from_appcast(appcast_xml.encode("utf-8"))
+        assert result is not None
+        assert result.get("short_version") == "0.0.4-test"
+        download_url = result.get("download_url")
+        assert download_url is not None
+        assert download_url.startswith("https://")
+        assert "releases/download" in download_url
+        assert "0.0.4-test" in download_url