Skip to content

CLI parameter --force now updates existing item instead of adding it multiple times #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
familie-laut wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CLI parameter --force now updates existing item instead of adding it multiple times #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 26 additions & 14 deletions loxicon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,23 +44,35 @@ def add_icon_svg(zf, iconPath, iconName, force=False):
#
def add_icon_xml(ixml, iconName, index, tags, line, filled, force=False):
iconRoot = ixml.getroot()

existing = iconRoot.find(f'Icon[@Id="{iconName}"]')

if existing is not None and force is False:
print(f'Skipping: {existing.attrib["Id"]}')
# find an existing element
elem = iconRoot.find(f'Icon[@Id="{iconName}"]')

if elem is None:
# not found -> create a new element
elem = ET.Element('Icon')
elem.set('Id', iconName)
is_new = True
else:
is_new = False

if not is_new and force is False:
print(f'Skipping: {elem.attrib.get("Id")}')
return None

newIcon = ET.Element('Icon',
uuid = str(loxUUID(index)),
Id = iconName,
Tags = ','.join(tags),
line = str(line).lower(),
filled = str(filled).lower())

print('Adding xml:', ET.tostring(newIcon, encoding='unicode'))
iconRoot.append(newIcon)
return True
# set/update attributes in one place
elem.set('uuid', str(loxUUID(index)))
elem.set('Tags', ','.join(tags) if tags else '')
elem.set('line', str(line).lower())
elem.set('filled', str(filled).lower())

if is_new:
print('Adding xml:', ET.tostring(elem, encoding='unicode'))
iconRoot.append(elem)
else:
print('Updated xml:', ET.tostring(elem, encoding='unicode'))

return True



Expand Down