This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Allow non-integral values for kafka_span_sample_rate_percent #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerald Rule: Copy Observability on Veneur and Unilog pull requestscc @stripe/observability |
ChimeraCoder
force-pushed
the
aditya-kafka-percent
branch
from
e02cd0a to
1a8a7c7
Compare
Contributor
Author
|
Joshu is OOO this week r? @cory-stripe |
Contributor
|
👍 From looking at the code it doesn't care of it's a float or not once the signature was fixed. Assuming tests pass looks great! |
sdboyer-stripe
approved these changes
May 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow non-integer values for the Kafka sample rate. This allows us to sample at rates less than 1% (or rates in between integer values).
Motivation
Test plan
Rollout/monitoring/revert plan
r? @joshu-stripe
cc @stripe/observability