This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Track errors when recording spans #290
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerald Rule: Copy Observability on Veneur and Unilog pull requestscc @stripe/observability |
asf-stripe
suggested changes
Oct 25, 2017
Contributor
asf-stripe
left a comment
asf-stripe
left a comment
There was a problem hiding this comment.
I think only one blocker on this. Otherwise: AWESOME
| cl.statsMtx.Lock() | ||
| defer cl.statsMtx.Unlock() | ||
| tags := []string{fmt.Sprintf("error:%s", err.Error())} | ||
| cl.stats.Incr("veneur.trace.record.errors_total", tags, 0.1) |
Contributor
There was a problem hiding this comment.
I think the metrics prefix that we set on our statsd client will cause the metric to be reported as veneur.veneur.trace.<...>. I wonder if SetErrorStats should have a sister method to set the metric name, too.
| } | ||
| } | ||
|
|
||
| type IncrClient interface { |
Contributor
There was a problem hiding this comment.
Can/should this interface get docs?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If we're encountering an error when recording a span, we want to know about it! This helps us catch situations like dropping spans due to the channel buffer being full.
Motivation
Test plan
Rollout/monitoring/revert plan
r? @asf-stripe
cc @stripe/observability