Skip to content

Conversation

@D4rkDuck
Copy link

PR Details

Manually removed the folder .vs folder containing 2 files.

Related Issue

#2964

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@D4rkDuck
Copy link
Author

@dotnet-policy-service agree

@D4rkDuck
Copy link
Author

D4rkDuck commented Dec 14, 2025

Related to testing out these changes:

I assume these changes do not require testing, but I nonetheless built the GameStudio and started the MaterialShader Sample successfully. I also tested whether creating a new .vs folder with any file would add it back, even though the gitignore shouldn't allow that. It did not, so is now working as intended.
I would actually not really know if there are any specific areas, that could be affected by the removal of a .vs folder. Could a more knowledgeable maintainer let me know where stride might be affected by such changes for learning purposes?

@D4rkDuck D4rkDuck changed the title removed expectedly ignored vs directory fix: removed expectedly ignored vs directory Dec 14, 2025
@Kryptos-FR
Copy link
Member

There shouldn't be any are affected since a .vs folder is local to a given developer. It's only needed by Visual Studio and doesn't influence the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants