Skip to content

Conversation

@Eideren
Copy link
Collaborator

@Eideren Eideren commented Oct 16, 2025

PR Details

Running the following

model.Meshes.Add(new CubeProceduralModel().Generate(game.Services).Meshes[0]);

throws when a ModelComponent was already in the scene in the preceding frame.
Fixes other similar errors, like when swapping one of the mesh, or one of the meshes' draw.

Also refactored around one of the failing method a bit to improve readability, splitting the logic into two explicit sections by flattening the inner scopes.

Related Issue

None.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren merged commit ddf6a01 into stride3d:master Oct 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant