Skip to content

fix: Use standard equality comparison for Int2/Int3 #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Eideren merged 1 commit into from
Oct 16, 2025
Merged

fix: Use standard equality comparison for Int2/Int3 #2934

Eideren merged 1 commit into from
Oct 16, 2025

Conversation

@Eideren
Copy link
Collaborator

@Eideren Eideren commented Oct 15, 2025

PR Details

Probably a copy/paste mistake from Vec2 -> Int2 - Int4 does not have this issue

Related Issue

None

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren added the area-Math Issues related to the Stride.Core.Mathematics namespace label Oct 15, 2025
@Eideren Eideren merged commit 6a3aaa8 into stride3d:master Oct 16, 2025
8 checks passed
@Eideren Eideren deleted the vecint_equality branch October 16, 2025 08:15
Acissathar added a commit to Acissathar/stride that referenced this pull request Oct 16, 2025
@Acissathar
Merge fix: Int2-3 Equality using MathF and tolerance (stride3d#2934)
af009c5 
commit 6a3aaa8
Author: Eideren <contact@eideren.com>
Date:   Thu Oct 16 10:15:46 2025 +0200

    fix: Int2-3 Equality using MathF and tolerance (stride3d#2934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kryptos-FR Kryptos-FR Kryptos-FR approved these changes

Assignees

No one assigned

Labels

area-Math Issues related to the Stride.Core.Mathematics namespace

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Eideren @Kryptos-FR