Skip to content

Conversation

@azeno
Copy link
Collaborator

@azeno azeno commented Jul 18, 2025

PR Details

A relevant lock statement on the internal GraphicsDevice.Resources collection was missing.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

…me creating textures in a background thread

A relevant lock statement on the internal GraphicsDevice.Resources collection was missing.
@Eideren
Copy link
Collaborator

Eideren commented Aug 27, 2025

Looks like there are other places in the source where device.Resources is accessed without a lock, it looks to me like those spots could also be problematic ?

@azeno
Copy link
Collaborator Author

azeno commented Aug 27, 2025

Ok can you point me to them? I remember I did a quick search and all the other places looked good to me.

@Eideren
Copy link
Collaborator

Eideren commented Aug 27, 2025

@azeno
Copy link
Collaborator Author

azeno commented Aug 27, 2025

@Eideren Thanks, updated

@Eideren Eideren merged commit 714eb63 into stride3d:master Aug 28, 2025
7 checks passed
@Eideren Eideren changed the title [Graphics] Fixes crash when resizing render window and at the same time creating textures in a background thread fix: crash when resizing render window and at the same time creating textures in a background thread Aug 28, 2025
@Eideren
Copy link
Collaborator

Eideren commented Aug 28, 2025

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants