-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Wip: Initial work on running game from the new editor #2796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: xplat-editor
Are you sure you want to change the base?
Conversation
Kryptos-FR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review. I'll have a second look at it later. I'm busy this weekend.
sources/editor/Stride.GameStudio.Avalonia/Stride.GameStudio.Avalonia.csproj
Outdated
Show resolved
Hide resolved
sources/editor/Stride.GameStudio.Avalonia/ViewModels/MainViewModel.cs
Outdated
Show resolved
Hide resolved
sources/editor/Stride.GameStudio.Avalonia/ViewModels/MainViewModel.cs
Outdated
Show resolved
Hide resolved
sources/editor/Stride.GameStudio.Avalonia/ViewModels/MainViewModel.cs
Outdated
Show resolved
Hide resolved
sources/editor/Stride.GameStudio.Avalonia/Views/MainWindow.axaml.cs
Outdated
Show resolved
Hide resolved
…nto xplat-editor
|
i reopened this one sorry for the other one I don't work with github a lot so I forget sometimes |
sources/Directory.Packages.props
Outdated
| <AvaloniaBehaviorVersion>11.2.7.3</AvaloniaBehaviorVersion> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageVersion Include="Avalonia" Version="$(AvaloniaVersion)" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be removed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i did that i keeped this one now and the other has been removed in past commit but it's still there idk why
sources/editor/Stride.GameStudio.Avalonia/Stride.GameStudio.Avalonia.csproj
Outdated
Show resolved
Hide resolved
| </DrawingImage> | ||
|
|
||
| <DrawingImage x:Key="ImageStart"> | ||
| <DrawingImage.Drawing> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 spaces instead of tabs for indentation in XAML files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to still be a mix of spaces and tabs.
If you are using Visual Studio, you can use Ctrl+E,D to format the current document. Or In Visual Studio code Ctrl+Shift+i.
Thanks for that yeah it's better for it to become a draft since I will not be able to work on it this month so I will be back at the start of July, I did make the run in editor on windows work with shortcut key and the run button but the run button is just put there randomly I still need to learn about the new editor layout and also more about avalonia so that I can make a similar design and positioning like the wpf editor, when I come back to coding in July I will try my best to finish the pr if I find the time |
|
Is there anyone who can test this PR? It works fine for me — just open the project and press F5 or click the Run button. |
I have created project in 4.2.0.2293 and then open in |
I think it's because the actually source project is version 4.2.0.1 for some reason build and run from source the Stride.GameStudio csproj and create a project then build and run the Stride.GameStudio.Avalonia.Desktop and open the project created from the stride version from source since it's a different version I had the same problem before |
|
So, have a problem on my side with
|
|
@Kryptos-FR Sorry for the mention — I think I’m done with these changes, but there are still some conflicts I couldn’t fix. Probably because the latest changes also touched the same files I modified. If you’ve got some time, a bit of guidance would really help. |
|
@ourabigdev the |
|
@ourabigdev I'll take care of the reformatting of the |
oh ok thanks i tried too i still need to learn a lot thanks for the help though i couldn't figured out that. this kind of situation helps me learn more |
24ca030 to
58587d8
Compare
|
Done. I resolved the conflict by merging the latest |
oh thanks for resolving it, i didn't think about that, also did you try the latest changes i made did it work for you did project build and run |
|
@Kryptos-FR i think i am done here any changes needed just let me know i thinks it's ready |
|
I couldn't make it work on my side. Can you give me some details of your own setup:
In the old game studio, we use a different library to parse the csproj, figure out the path to a compatible MSBuild and then use that API to do the build. We don't call the command line directly. Now with that said, I think it is good to experiment calling the command line because the other API is hard to work with. But at the moment it doesn't seem to work with a simple project created from the new game template. |
i have .net 8 and for visual studio i have the setup from the stride github readme, for the stride project i am using i specifically told him to use dotnet 8 in a global.json file since i have both .net 8 and 9 installed. |
2025-11-08.19-31-09.mp4it's working for me can you tell me wich error you get or is it just not working |
|
It seems it doesn't work if there is no This issue is outside the scope of the current PR. So I'm going to accept it as-is and we will investigate later how to fix it. |
yeah that is the problem i had too the project i created inside stride mix dotnet 8 and 9 that i have in my device so unless i add global.json to the stride test project telling it to use dotnet 8 it doesnt work wich is weird |
|
@Kryptos-FR sorry for the bother but since i will be having exams next month i wanted to know if there is something that will need to be added to this pr before being merged or no |
|
@ourabigdev I think I'll probably merge it as-is. Or push some more commits myself before doing so. Since the target branch So don't worry and focus on your exams. That's more important. |
PR Details
This PR adds the ability to build the game project from within the new Avalonia-based editor. While the editor UI doesn't yet include a button for this feature, the F5 shortcut can be used to trigger the build.
Currently, this functionality only works on Windows due to the limitations of the Stride AssetCompiler, which is platform-specific. I have started laying the groundwork for supporting other platforms in the future, but I am currently unable to test this feature on my Linux machine.
Related Issue
Fixes or relates to issue: #2742
Types of changes
Checklist