-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: Improve CI workflows #2794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
04ad478 to
5044955
Compare
5044955 to
4795411
Compare
It will only run when the build itself is modified, or when triggered manually
VaclavElias
approved these changes
May 23, 2025
Collaborator
|
I'll let xen2 chime in on this one - this is really not my area of expertise |
xen2
approved these changes
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Improve the jobs and workflows by separating workflows triggered on a push to
masterand workflows run automatically on PRs.Related Issue
Follows #2789.
Description
The
main.ymlis for Continuous Integration (CI) and will only be triggered onpushtomaster.Each reusable workflow (e.g.
build-windows-runtime.yml) will run on a PR (but not on a draft) if it makes sense given the paths of the modified files. For example, if onlysources/editor/**files are modified, runtime-only workflows won't run.Notes:
In this PR, the
build-android.ymlworkflow is broken because of some issue at the NDK level with the components present on the runner hosts. We likely need to upgrade the minimum version (I think we are still usingr21) and fix the paths of some dependencies that changed in more recent releases of the NDK. I tried to fix it by using the setup-ndk@v1 action, but that didn't work.The
test-linux.ymlworkflow is also broken and will be fixed later in the context of the editor rewrite. It is not triggered automatically.Types of changes
Checklist