Skip to content

Conversation

@Kryptos-FR
Copy link
Member

PR Details

Improve the jobs and workflows by separating workflows triggered on a push to master and workflows run automatically on PRs.

Related Issue

Follows #2789.

Description

The main.yml is for Continuous Integration (CI) and will only be triggered on push to master.

Each reusable workflow (e.g. build-windows-runtime.yml) will run on a PR (but not on a draft) if it makes sense given the paths of the modified files. For example, if only sources/editor/** files are modified, runtime-only workflows won't run.

Notes:

In this PR, the build-android.yml workflow is broken because of some issue at the NDK level with the components present on the runner hosts. We likely need to upgrade the minimum version (I think we are still using r21) and fix the paths of some dependencies that changed in more recent releases of the NDK. I tried to fix it by using the setup-ndk@v1 action, but that didn't work.

The test-linux.yml workflow is also broken and will be fixed later in the context of the editor rewrite. It is not triggered automatically.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Kryptos-FR Kryptos-FR self-assigned this May 21, 2025
@Kryptos-FR Kryptos-FR marked this pull request as ready for review May 21, 2025 12:24
@Kryptos-FR Kryptos-FR requested a review from VaclavElias May 21, 2025 12:32
@Kryptos-FR Kryptos-FR force-pushed the feature/github-ci-pr branch from 04ad478 to 5044955 Compare May 21, 2025 13:00
@Kryptos-FR Kryptos-FR force-pushed the feature/github-ci-pr branch from 5044955 to 4795411 Compare May 21, 2025 19:28
It will only run when the build itself is modified, or when triggered manually
@Kryptos-FR Kryptos-FR requested review from Eideren and xen2 May 23, 2025 15:16
@Eideren
Copy link
Collaborator

Eideren commented May 24, 2025

I'll let xen2 chime in on this one - this is really not my area of expertise

@Kryptos-FR Kryptos-FR merged commit f99bde2 into stride3d:master May 25, 2025
10 of 11 checks passed
@Kryptos-FR Kryptos-FR deleted the feature/github-ci-pr branch May 26, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants