-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Drop support for UWP #2450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Drop support for UWP #2450
Conversation
|
This test is missing " I have built and run the editor to try this change out." 🤣 |
|
@VaclavElias Welp...Testing always takes more time, but if you want to help speed it up, feel free to test it by yourself 😜 |
625d4af to
5dc95fa
Compare
Eideren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of notes
| if (Platform.Type != PlatformType.Windows && Platform.Type != PlatformType.UWP) | ||
| throw new NotSupportedException(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is wrong, it should still throw when the platform is not windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my you're right, Fixed!
| #if STRIDE_GRAPHICS_API_DIRECT3D11 && STRIDE_PLATFORM_UWP | ||
| if (Windows.Graphics.Holographic.HolographicSpace.IsAvailable && GraphicsDevice.Presenter is WindowsMixedRealityGraphicsPresenter) | ||
| { | ||
| Device = new WindowsMixedRealityHmd(); | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to throw a not supported here instead of silently failing ? Granted that's what it would have done before outside of UWP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, It sounds reasonable instead of getting nothing. Fixed!
|
Should we reconsider this PR in light of .NET 9 adding legacy support for UWP? At the very least it helps us migrate Stride users away from 4.0 and .NET Framework if they want UWP support. https://devblogs.microsoft.com/ifdef-windows/preview-uwp-support-for-dotnet-9-native-aot/ |
|
@MeharDT I was not aware of this one, you're right, we'll revisit this issue whenever UWP support becomes problematic then |
|
I marked PR as draft for now. We'll see what happens next with UWP support |
cec3aa5 to
ef9cc39
Compare
ef9cc39 to
68cdc6a
Compare
|
I decided to reopen PR, because It seems UWP support in net9.0 was only temporary solution for customers to get some time to migrate to other solution. Anyways, feel free to review my PR ! |
The dev blog I linked to was updated to include mention of .NET 10 templates for UWP in VS 2026. Was anyone able to deploy these to an Xbox One or Series console? If they work on console, I think we should delay removal until GDK support can be implemented so we don't lose another platform. If they only work on PC, we might as well remove it now. |
|
Oh, I didn't notice that good to know 😅. In that case, we can indeed delay removal until we check whether UWP still works on XBOX, or we can start implementing GDK now, although to be honest, console support is not a priority for me at the moment. |
PR Details
This PR drops support for UWP and it's codebase.
The main reason is that UWP support has been abandoned since .NET 5 and Microsoft recommends to migrate to MS GDK for Xbox consoles.
That said, the last version that targeted .NET 5 version was a very long time ago (4.1.0.1459-beta) and this PR is also intended to avoid unnecessary frustration for new developers over a feature that is long gone.
Types of changes
Checklist