forked from streetslab/dimelo-toolkit
-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/dm 191 refactor load processed pileup #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thekugelmeister
merged 29 commits into
main
from
feature/DM-191-refactor-load-processed
May 31, 2025
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
b2b7689
DM-229 Consolidating parsing logic for load_processed functions. Stil…
3f3ec85
DM-231 Removed regions=None case for pileup_counts_from_bedmethyl bec…
91fb5e4
DM-229 Adjusted export.pileup_to_bigwig to use new load_processed.pro…
53d039b
DM-192 Implemented parallelization core including shared memory and c…
caf9dcd
DM-232 Added strand information to regions .bed files. Re-generated r…
64a9f65
DM-232 Added single_strand and regions_5to3prime to cases.py. Adjuste…
bb526bf
Merge pull request #16 from streetslab/feature/DM-191-refactor-load-p…
OberonDixon caa3e59
DM-192 Fixed logic to properly handle single_strand case within proce…
ac3657e
DM-192 Further refactor to simplify process_pileup_row and keep regio…
a9648df
DM-192 Added chunk_size for load_processes parallelization to cases.p…
c830abf
Merge pull request #17 from streetslab/feature/DM-191-refactor-load-p…
OberonDixon 7301d3d
DM-192,DM-236,DM-233,DM-235 Parallelized pileup_counts_from_bedmethyl…
56e6333
DM-192,DM-236 Properly close and delink shared memory when appropriat…
97efec1
DM-191 Re-arrange contents of load_processed for better clarity. Adde…
a8ed1ae
DM-238 Add quiet and cores parameters and corresponding documentation…
f1b0758
DM-239 Added test case coverage for 1-4 cores. GitHub jobs for Ubuntu…
0b68892
DM-239 Added cases.py support for cores=None. Tweaked dimelo_test.py …
1da3d3c
DM-239 Adjusted generate_targets module to properly handle cores argu…
fcf116f
Ruff format fixes
5dad63b
Merge pull request #18 from streetslab/feature/DM-191-refactor-load-p…
OberonDixon f0f027b
Merge branch 'main' into feature/DM-191-refactor-load-processed
OberonDixon bd94e78
Fixed small mistakes from merge
0a9feb0
Merge branch 'main' into feature/DM-191-refactor-load-processed
OberonDixon 4454f67
Added check for chrom in tabixfile.
bfdbff6
DM-191 Adjustments in response to PR comments from thekugelmeister
d3cc71c
Merge branch 'feature/DM-191-refactor-load-processed' of https://gith…
7f50782
Adjust naming for regions_to_list region-splitting parallelization pa…
3ce0e8f
attempting to fix ruff versioning
thekugelmeister 2972c34
ruff version fix attempt 2
thekugelmeister File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much appreciate the simplification!