Rename agent entity from "agentdef" to "agent"#1
Merged
Conversation
krmrn42
requested changes
Oct 19, 2025
Member
krmrn42
left a comment
krmrn42
left a comment
There was a problem hiding this comment.
I suggest to name the claim "agent_name" as it matches the UI and YAML model.
src/index.js
Outdated
| if (!agentDefinitionName) { | ||
| throw new Error('claims must include an "agent_definition" key'); | ||
| // Extract agent from claims | ||
| const agentName = claims.agent; |
Member
There was a problem hiding this comment.
we still call this "Agent Name" in the portal UI and YAML, so I suggest keep it "agent_name" in the action parameters.
Contributor
Author
There was a problem hiding this comment.
Thank you, fixed. Pls let me know what else I've missed during refactoring.
krmrn42
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.