Skip to content

Clean up warnings in github actions #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
summeroff wants to merge 5 commits into
base: staging
Choose a base branch
from
Open

Clean up warnings in github actions #1621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2d4eaa6
fix github actions warnings
summeroff Jan 6, 2026
2aced9c
fix more warnings
summeroff Jan 6, 2026
08dd244
fix github actions warnings
summeroff Jan 6, 2026
d078ba9
fix more warnings
summeroff Jan 6, 2026
fcf88f7
fix more warnings
summeroff Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@
submodules: 'recursive'
- name: Get the version
id: get_version
run: echo "VERSION=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_OUTPUT
run: echo "VERSION=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV
shell: bash
- name: Install Node.js
uses: actions/setup-node@v3
with:
node-version: '18.x'
node-version: '20.x'
- name: Install dependencies
shell: bash
run: './ci/install-dependencies-osx.sh'
Expand Down Expand Up @@ -125,7 +125,7 @@
- name: Install Node.js
uses: actions/setup-node@v3
with:
node-version: '18.x'
node-version: '20.x'
- name: Install dependencies
shell: bash
run: './ci/install-dependencies-osx.sh'
Expand Down Expand Up @@ -190,7 +190,7 @@
TARGET_ARTIFACT: ${{env.PACKAGE_NAME}}-${{ steps.get_version.outputs.VERSION }}-${{matrix.ReleaseName}}-${{env.OS_TAG}}-${{matrix.Architecture}}
- name: Configure AWS credentials
if: startsWith(github.ref, 'refs/tags/')
uses: aws-actions/configure-aws-credentials@v1
uses: aws-actions/configure-aws-credentials@v4

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'CI Multiplatform Build' step
Uses Step
Loading
uses 'aws-actions/configure-aws-credentials' with ref 'v4', not a pinned commit hash
with:
aws-access-key-id: ${{secrets.AWS_RELEASE_ACCESS_KEY_ID}}
aws-secret-access-key: ${{secrets.AWS_RELEASE_SECRET_ACCESS_KEY}}
Expand Down Expand Up @@ -278,7 +278,7 @@
id: get_version
run: |
$version = $env:GITHUB_REF -replace 'refs/tags/', ''
"VERSION=$version" | Out-File -FilePath $env:GITHUB_OUTPUT -Encoding utf8 -Append
"VERSION=$version" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
shell: pwsh
- name: Install dependencies
run: |
Expand Down Expand Up @@ -372,7 +372,7 @@
TARGET_ARTIFACT: ${{env.PACKAGE_NAME}}-${{ steps.get_version.outputs.VERSION }}-release-${{env.OS_TAG}}
- name: Configure AWS credentials
if: startsWith(github.ref, 'refs/tags/')
uses: aws-actions/configure-aws-credentials@v1
uses: aws-actions/configure-aws-credentials@v4

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'CI Multiplatform Build' step
Uses Step
Loading
uses 'aws-actions/configure-aws-credentials' with ref 'v4', not a pinned commit hash
with:
aws-access-key-id: ${{secrets.AWS_RELEASE_ACCESS_KEY_ID}}
aws-secret-access-key: ${{secrets.AWS_RELEASE_SECRET_ACCESS_KEY}}
Expand Down
30 changes: 23 additions & 7 deletions ci/install-dependencies-osx.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,27 @@
# Install system dependencies
#!/bin/bash
set -e

# Remove preinstalled deprecated/disabled formulae and casks
brew uninstall --ignore-dependencies openssl@1.1 2>/dev/null || true
brew uninstall --cask session-manager-plugin 2>/dev/null || true

# Remove unnecessary local taps (these cause warnings on GitHub runners)
brew untap homebrew/core 2>/dev/null || true
brew untap homebrew/cask 2>/dev/null || true

# Clean up broken symlinks and outdated packages
brew cleanup 2>/dev/null || true

# Update Homebrew
brew update
brew doctor
brew install cmake
brew install python
brew install node@18
export PATH="/usr/local/opt/node@18/bin:$PATH"
node -v

# Only install cmake if not already present
if ! command -v cmake &> /dev/null; then
brew install cmake
fi

# Verify cmake
cmake --version

# Install module dependencies
yarn install
Expand Down
Loading