Add exporters and support for mutli-exporter #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheffner
reviewed
Jul 28, 2025
Contributor
mheffner
left a comment
mheffner
left a comment
There was a problem hiding this comment.
looks good, mostly would recommend bumping to v23 (I'm about to do same for pyrotel)
| static kafka_exporter(config?: Partial<KafkaExporter>): KafkaExporter { | ||
| return { | ||
| _type: "kafka", | ||
| security_protocol: "plaintext", |
Contributor
There was a problem hiding this comment.
Curious why this has to be specified?
Contributor
Author
There was a problem hiding this comment.
Got an error that it was unspecified and needed to be from rdkafka iirc, suspect it was related to the command line arg changes
Contributor
There was a problem hiding this comment.
I believe that is now fixed in the latest release.
Contributor
Author
There was a problem hiding this comment.
That's what I was thinking
Co-authored-by: Mike Heffner <mikeh@fesnel.com>
…js into multiple_exporters
mheffner
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes: STR-3494
This PR brings rotel-nodejs up to the latest release of rotel and adds support for the Datadog, Kafka, Blackhole, and Clickhouse exporters. Additionally we've modified the configuration to support multiple exporters. We've tested locally by building the latest main branch of rotel and swapping out the
rotel-agentbinary in the node_modules/@streamfold/bin directory. Additionally we've tested all exporters with the rotel-nodejs-hello-world project, linking to this branch and changes on the local filesystem via modifying package.json like so.We should follow up with more comprehensive unit testing in additional PRs.