Skip to content

fix(ci): add libfdk-aac-dev to marketplace build dependencies #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
streamer45 merged 1 commit into from
Apr 7, 2026
Merged

fix(ci): add libfdk-aac-dev to marketplace build dependencies #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/marketplace-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
- name: Install system dependencies
run: |
sudo apt-get update
sudo apt-get install -y cmake pkg-config libclang-dev libfontconfig1-dev wget libopenblas-dev zstd patchelf python3-yaml python3-tomli
sudo apt-get install -y cmake pkg-config libclang-dev libfontconfig1-dev wget libopenblas-dev zstd patchelf python3-yaml python3-tomli libfdk-aac-dev
Copy link
Copy Markdown
Contributor Author

@staging-devin-ai-integration staging-devin-ai-integration bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 plugins.yml CI missing lint/format checks for aac-encoder

The plugins.yml workflow (.github/workflows/plugins.yml) has format and clippy lint jobs for most native plugins (vad, whisper, kokoro, piper, matcha, sensevoice, nllb, slint) but does not include the aac-encoder plugin. This means the aac-encoder plugin won't get format or clippy checks in CI. This is a pre-existing gap from the PR that added the aac-encoder plugin (#261), not introduced by this PR, but it's worth noting since this PR is specifically about making the aac-encoder build work in CI pipelines.

Staging: Open in Devin

Was this helpful? React with 👍 or 👎 to provide feedback.

Debug

Playground


- name: Install minisign
run: |
Expand Down
Loading