feat(agent): add generic type parameter to AgentState.getAll()#575
Open
NickEckardt wants to merge 1 commit intostrands-agents:mainfrom
Open
feat(agent): add generic type parameter to AgentState.getAll()#575NickEckardt wants to merge 1 commit intostrands-agents:mainfrom
NickEckardt wants to merge 1 commit intostrands-agents:mainfrom
Conversation
The get, set, and delete methods all accept a <TState> generic for type-safe state access, but getAll() forced callers to use `as` casts. This adds a generic overload so callers can opt into a narrower return type (e.g. state.getAll<AppState>()) without a cast, while the unparameterized overload continues to return Record<string, JSONValue>. No runtime behavior changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get, set, and delete methods all accept a generic for type-safe state access, but getAll() forced callers to use
ascasts. This adds a generic overload so callers can opt into a narrower return type (e.g. state.getAll()) without a cast, while the unparameterized overload continues to return Record<string, JSONValue>.No runtime behavior changes.
Description
Adds a generic overload to
AgentState.getAll()matching the existing pattern onget,set, anddelete. Callers can now writestate.getAll<MyState>()instead ofstate.getAll() as MyState. Theextends Record<string, JSONValue>constraint ensures only compatible types can be asserted. The unparameterizedgetAll()overload continues to returnRecord<string, JSONValue>— no breaking changes.Related Issues
None
Documentation PR
None — no new public API surface, just an additional overload on an existing method.
Type of Change
New feature
Testing
How have you tested the change?
npm run checkChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.