Skip to content

chore: Remove deprecated eslint-env comments#521

Open
alisayeed248 wants to merge 3 commits intostrands-agents:mainfrom
alisayeed248:deprecated-eslint-comments
Open

chore: Remove deprecated eslint-env comments#521
alisayeed248 wants to merge 3 commits intostrands-agents:mainfrom
alisayeed248:deprecated-eslint-comments

Conversation

@alisayeed248
Copy link

Description

Removes /* eslint-env */ comments from bash.ts and http-request.ts. These comments are deprecated in ESLint's flat config system and will become errors in ESLint v10.

ESLint v9.39.2, December 12, released a warning that warns when eslint-env configuration comments are found.
https://github.com/eslint/eslint/releases/tag/v9.39.2

Right now we get this warning upon running npm run lint:
image

Right now they're warnings, but ESLint v10.0.0 will report them as errors , which was released a few days ago.

The comments right now are defensive but can be removed because both files either declare Node or browser specific variables/functions in eslint.config.js, using explicit imports/ inline eslint-disable comments, or globalThis.

Related Issues

Documentation PR

Type of Change

Other (please describe):
Maintenance cleanup

Testing

How have you tested the change?

  • I ran npm run check
  • I ran npm run lint and the warnings are gone

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot added the strands-running <strands-managed> Whether or not an agent is currently running label Feb 13, 2026
@github-actions
Copy link

Assessment: ✅ Approve

Clean maintenance PR that removes deprecated eslint-env comments ahead of ESLint v10. The flat config in eslint.config.js already properly configures the necessary globals (process, console, etc.), and both files use explicit imports rather than relying on global environment declarations.

Verification Summary
  • Globals Configuration: eslint.config.js defines process, console, window, document, navigator in the appropriate scopes
  • Import Pattern: Files use explicit imports (spawn, ChildProcess from child_process, Buffer from buffer) rather than relying on global Node.js environment
  • Scope: Minimal change (2 lines), no functional impact

Good proactive cleanup! 👍

@github-actions github-actions bot removed the strands-running <strands-managed> Whether or not an agent is currently running label Feb 13, 2026
@github-actions github-actions bot added strands-running <strands-managed> Whether or not an agent is currently running and removed strands-running <strands-managed> Whether or not an agent is currently running labels Feb 13, 2026
@mkmeral mkmeral enabled auto-merge February 13, 2026 16:29
@mkmeral mkmeral added this pull request to the merge queue Feb 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2026
@mkmeral mkmeral added this pull request to the merge queue Feb 18, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants