chore: Remove deprecated eslint-env comments#521
Open
alisayeed248 wants to merge 3 commits intostrands-agents:mainfrom
Open
chore: Remove deprecated eslint-env comments#521alisayeed248 wants to merge 3 commits intostrands-agents:mainfrom
alisayeed248 wants to merge 3 commits intostrands-agents:mainfrom
Conversation
… into deprecated-eslint-comments
|
Assessment: ✅ Approve Clean maintenance PR that removes deprecated Verification Summary
Good proactive cleanup! 👍 |
pgrayy
reviewed
Feb 13, 2026
pgrayy
approved these changes
Feb 13, 2026
mkmeral
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
/* eslint-env */comments frombash.tsandhttp-request.ts. These comments are deprecated in ESLint's flat config system and will become errors in ESLint v10.ESLint v9.39.2, December 12, released a warning that warns when eslint-env configuration comments are found.
https://github.com/eslint/eslint/releases/tag/v9.39.2
Right now we get this warning upon running npm run lint:

Right now they're warnings, but ESLint v10.0.0 will report them as errors , which was released a few days ago.
The comments right now are defensive but can be removed because both files either declare Node or browser specific variables/functions in eslint.config.js, using explicit imports/ inline eslint-disable comments, or globalThis.
Related Issues
Documentation PR
Type of Change
Other (please describe):
Maintenance cleanup
Testing
How have you tested the change?
npm run checknpm run lintand the warnings are goneChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.