VRTのsnapshot更新時に変更されたsnapshotのbefore/afterをコメントで表示するようにする #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stotic-dev
added
mentenance
stotic-dev
force-pushed
the
update/show_snapshot_diff_on_danger
branch
from
098d383 to
d807939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
経緯
この発表に触発されて、Dangeerを使ってVRTの差分表示をもっと簡単に確認できるようにして、どのような差分が出ているかをPRでぱっと見で確認できるようにします。
実装内容
Dangerでマージ先と変更ブランチのsnapshotのファイルパスと、それぞれのブランチのshaを取得して、画像のURLを取得し、マークダウンでDangerのコメントを貼るようにしました。
shaによるURLの生成なので、ブランチが消されようと、コメントで表示される画像は基本的に永続化されます。
確認内容