Conversation
- Updated test cases for `set_permission` and `set_all_permissions` methods to improve coverage. - Added tests for handling unregistered IP accounts, invalid signer addresses, and invalid transaction addresses. - Introduced tests for creating permission signatures with validation for deadlines. - Enhanced error handling in tests to ensure proper exception messages are raised.
- Removed hardcoded chain ID values and replaced them with the CHAIN_ID constant for better maintainability. - Improved formatting of error messages for environment variable checks. - Cleaned up unnecessary code related to Python path adjustments.
Co-authored-by: bpolania <boris.polania@gmail.com>
Co-authored-by: bpolania <boris.polania@gmail.com>
- Introduced a new .coveragerc file to specify coverage settings, omitting certain files and directories. - Updated README to include instructions for running tests with coverage and generating a coverage report.
bonnie57
requested review from
AndyBoWu,
edisonz0718,
limengformal,
lucas2brh and
sebsadface
as code owners
bonnie57
changed the base branch from
main
to
feat/refactor-permission-unit-test
bonnie57
force-pushed
the
feat/refactor-permission-unit-test
branch
from
0ffdf21 to
b20ee01
Compare
lucas2brh
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
READMEon how to get the test reportHow to run the command
Run unit tests
Generating a Coverage Report
or
Test Plan
Test result