Merged
Conversation
aandrewchung
requested review from
DracoLi,
bpolania,
edisonz0718 and
sebsadface
as code owners
bpolania
reviewed
Apr 16, 2025
bpolania
reviewed
Apr 16, 2025
bpolania
approved these changes
Apr 18, 2025
DracoLi
approved these changes
Apr 19, 2025
Contributor
DracoLi
left a comment
DracoLi
left a comment
There was a problem hiding this comment.
looks good. comments are non-blocking.
| ip_id, | ||
| signer, | ||
| to, | ||
| Web3.keccak(text=func)[:4] if func else b'\x00\x00\x00\x00', |
Contributor
There was a problem hiding this comment.
can b'\x00\x00\x00\x00' be replace with bytes(4)?
Contributor
There was a problem hiding this comment.
nit: i saw this is used a few times here, maybe we can extract this function selector out? something like get_selector?
|
Looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test Plan
Related Issue
n/a
Notes